Fix high CPU usage with Safari browsers #114
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high CPU usage when using Shifty with Safari browser comes from:
To address this we can change the notification we listen too, specifically:
loadComplete
is triggered when a page finishes loading (to handle url change when user is navigating)focusedTabChanges
when changing between browser tabsWe still need to keep
uiElementDestroyed
to account for when a user leaves a full screen video window.We also only use the AX api to obtain the URL, which is faster and more lightweight.
I've been using those changes for almost two years so I wouldn't worry about the AX hierarchy stability!
This addresses #101 and #90