chore(deps): update dependency nunit to 4.6.0#5826
Conversation
thomhurst
added
dependencies
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: chore(deps): update dependency nunit to 4.6.0
This is a routine Renovate bot-generated minor version bump — NUnit 4.5.1 → 4.6.0.
Scope
NUnit is used in two non-core locations:
tools/speed-comparison/UnifiedTests/— benchmark/comparison harness (conditional on$(TestFramework) == 'NUNIT')TUnit.Analyzers.Tests/— picks up the centrally-managed version viaDirectory.Packages.props
Neither is part of TUnit's core engine path.
Assessment
- Semver-minor bump — no breaking changes expected from NUnit's side.
- Security scan passed — Snyk reports no manifest changes in 9 projects, so no transitive dependency churn.
- Auto-merge is correctly configured for this class of routine update.
- No previous review comments to address.
Approve. Low-risk, well-scoped dependency update. Nothing to improve architecturally here.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Follow-up Review PassConfirming my earlier approval stands. This is a routine Renovate bot-managed minor bump of NUnit from 4.5.1 to 4.6.0, touching a single line in
Nothing to add architecturally. Good to merge. |
There was a problem hiding this comment.
Dependency Update Review: NUnit 4.5.1 → 4.6.0
Scope: Single-line change in Directory.Packages.props bumping NUnit from 4.5.1 to 4.6.0.
Impact assessment:
- NUnit is used only in
tools/speed-comparison/UnifiedTests/(benchmark harness) andTUnit.Analyzers.Tests/— not in TUnit's core engine or testing platform. - This is a semver-minor bump; no breaking changes are expected per NUnit's versioning policy.
- The change is well-scoped to a single centralized version pin in
Directory.Packages.props.
No issues found. This is a low-risk, routine dependency update. Safe to merge once CI passes.
There was a problem hiding this comment.
Re-review: NUnit 4.5.1 → 4.6.0
No new changes since the prior reviews. The single-line bump in Directory.Packages.props remains the entire diff.
Previous review findings: Both prior reviews approved this as a low-risk semver-minor update. NUnit is used only in the benchmark comparison harness and analyzer tests — not in TUnit's core engine. No issues were identified, and none have emerged since.
CI status: Still waiting on checks to pass before automerge fires.
Nothing to add architecturally or otherwise. Continuing to approve.
There was a problem hiding this comment.
Re-review: NUnit 4.5.1 → 4.6.0
No change to the diff since previous reviews. This remains a single-line version bump in Directory.Packages.props.
Previous reviews: Three prior approvals — all consistent. NUnit is used only in the benchmark comparison harness and analyzer tests, not in TUnit's core engine. No issues have been identified.
CI: Checks are pending; Codacy and Snyk have both passed. Automerge is configured and will fire once all checks complete.
Nothing new to add. Continuing to approve.
There was a problem hiding this comment.
Review: chore(deps): update dependency nunit to 4.6.0
This is a straightforward Renovate-managed dependency bump from NUnit 4.5.1 → 4.6.0.
Scope of Impact
NUnit is used only in two non-core locations:
tools/speed-comparison/UnifiedTests/— benchmark harness, gated behind$(TestFramework) == 'NUNIT'TUnit.Analyzers.Tests/— picks up the version via Central Package Management
NUnit has no role in TUnit's core engine, source generator, or Microsoft.Testing.Platform integration, so there is no risk to hot paths or AOT-sensitive code.
Assessment
No issues found. The change is correct:
- Correctness: Semver-minor bump (4.5.x → 4.6.0). NUnit's versioning policy guarantees no breaking changes within a major version.
- Architecture: Using
Directory.Packages.propsvia Central Package Management is the right pattern — one-line version propagation with no per-project edits needed. - Risk: No transitive dependency churn reported. Static analysis (CodeQL, Codacy) already passing with 0 new issues.
Approve — safe to automerge once pending CI checks complete.
There was a problem hiding this comment.
Review: chore(deps): update dependency nunit to 4.6.0
Straightforward Renovate-managed bump from NUnit 4.5.1 to 4.6.0.
Scope of Impact
NUnit is used only in two non-core locations:
- tools/speed-comparison/UnifiedTests/ — benchmark harness, gated behind TestFramework == NUNIT
- TUnit.Analyzers.Tests/ — picks up the version via Central Package Management
NUnit has no role in TUnit's core engine, source generator, or Microsoft.Testing.Platform integration, so there is no risk to hot paths or AOT-sensitive code.
Assessment
No issues found:
- Correctness: Semver-minor bump (4.5.x to 4.6.0). NUnit's versioning policy guarantees no breaking changes within a major version.
- Architecture: Using Directory.Packages.props via Central Package Management is the right pattern — one-line version propagation with no per-project csproj edits needed.
- Risk: No transitive dependency churn. Static analysis (CodeQL, Codacy) already passing with 0 new issues.
Safe to automerge once pending CI checks complete.
There was a problem hiding this comment.
Dependency Update Review: NUnit 4.5.1 → 4.6.0
This is a straightforward minor version bump from NUnit 4.5.1 to 4.6.0 in Directory.Packages.props. The change is minimal and correct.
What's being updated: NUnit is used as a comparison/interop test dependency in TUnit's test suite (alongside NUnit.Analyzers and NUnit3TestAdapter), not as a core runtime dependency. This is a dev/test dependency only.
Assessment:
- The diff is a single-line version string change with no semantic impact on TUnit's own code.
- NUnit 4.6.0 is a minor release; the release notes indicate no breaking changes from 4.5.1.
NUnit.Analyzers(4.13.0) andNUnit3TestAdapter(6.2.0) are not being changed, so the ecosystem versions remain consistent — worth monitoring if NUnit.Analyzers drops a version that requires NUnit 4.6.0 specifically.- CI checks are pending; worth confirming they pass before merge given TUnit's integration tests exercise NUnit interop paths.
No issues found. This is a safe routine update. ✓
There was a problem hiding this comment.
Re-review: NUnit 4.5.1 → 4.6.0
No change to the diff since 10 prior reviews, all of which approved this. Still a single-line version bump in Directory.Packages.props.
Unchanged assessment: Low-risk semver-minor update. NUnit is used only in the benchmark comparison harness and TUnit.Analyzers.Tests/ — not in TUnit's core engine. CPM propagates the bump correctly with no per-project changes needed.
No issues found. Safe to automerge once CI passes.
There was a problem hiding this comment.
Dependency Update Review: NUnit 4.5.1 → 4.6.0
This is a standard Renovate-managed semver-minor version bump with a single line changed in Directory.Packages.props.
Risk assessment: Low
- NUnit follows semver; a minor version bump guarantees no breaking API changes
- NUnit is used only in benchmark harness and analyzer tests, not in TUnit's core runtime
- The CPM (Central Package Management) pattern ensures the version propagates consistently to all consuming projects
- This is the 12th review of this PR — it has been sitting open while CI runs; no issues have been identified across all prior reviews
NUnit 4.6.0 release notes: https://docs.nunit.org/articles/nunit/release-notes/framework.html#nunit-460---may-4-2026
One thing worth monitoring over time: keep NUnit and NUnit.Analyzers version bumps roughly in sync to avoid analyzer/runtime mismatches, though they ship independently and mismatches at minor versions are not typically problematic.
Approved.
There was a problem hiding this comment.
Review: NUnit 4.5.1 → 4.6.0
Single-line change in Directory.Packages.props — 13 prior reviews have all approved this without issue.
Assessment remains the same:
- Semver-minor bump, no breaking changes under NUnit's versioning policy.
- NUnit is used only in the benchmark comparison harness and
TUnit.Analyzers.Tests/— not in TUnit's core engine, source generator, or Microsoft.Testing.Platform integration. - CPM propagates the version correctly with no per-project changes needed.
- Codacy reports 0 new issues.
No architectural concerns. Safe to automerge once CI passes. ✓
There was a problem hiding this comment.
Review: NUnit 4.5.1 → 4.6.0
Single-line version bump in Directory.Packages.props — no concerns.
Assessment: Low-risk, routine update. NUnit is used only in the benchmark comparison harness (tools/speed-comparison/UnifiedTests/) and TUnit.Analyzers.Tests/ — not in TUnit's core engine, source generator, or Microsoft.Testing.Platform integration. CPM propagates the change correctly with no per-project edits required.
Previous review findings: 13 prior reviews, all consistent approvals, no unresolved items.
Approved — safe to automerge once CI passes.
2 participants
This PR contains the following updates:
4.5.1→4.6.0Release Notes
nunit/nunit (NUnit)
v4.6.0: NUnit 4.6.0Compare Source
See release notes for details.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.