Skip to content

Fix template reference in modular-backbone example. #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fix template reference in modular-backbone example. #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/modular-backbone/js/views/contributors/ContributorsListView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,22 +75,22 @@ define([
data.contributors = that.bronzeContributors;
data.podium = bronzePodium;

var bronzeCompiledTemplate = _.template( contributorListTemplate, data );
$("#bronze-podium").html( bronzeCompiledTemplate );
var bronzeCompiledTemplate = _.template( contributorListTemplate );
$("#bronze-podium").html( bronzeCompiledTemplate( data ) );

// render silver list
data.contributors = that.silverContributors;
data.podium = silverPodium;

var silverCompiledTemplate = _.template( contributorListTemplate, data );
var silverCompiledTemplate = _.template( contributorListTemplate );

$("#silver-podium").html( silverCompiledTemplate );
$("#silver-podium").html( silverCompiledTemplate( data ) );

// render gold list
data.contributors = that.goldContributors;
data.podium = goldPodium;
var goldCompiledTemplate = _.template( contributorListTemplate, data );
$("#gold-podium").html( goldCompiledTemplate );
var goldCompiledTemplate = _.template( contributorListTemplate );
$("#gold-podium").html( goldCompiledTemplate( data ) );

that.animate();

Expand Down
4 changes: 2 additions & 2 deletions examples/modular-backbone/js/views/contributors/ContributorsView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ define([
total_contributors : total_contributors};

// main view
var compiledTemplate = _.template( contributorsTemplate, data );
this.$el.html( compiledTemplate );
var compiledTemplate = _.template( contributorsTemplate );
this.$el.html( compiledTemplate( data ) );

// sub view
var contributorsListView = new ContributorsListView({ collection: this.collection});
Expand Down
4 changes: 2 additions & 2 deletions examples/modular-backbone/js/views/contributors/contributor/ContributorView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ define([

//var contributorTemplate = $('#contributor-underscore-template').html(); hmmmmm????

var rendered_template = _.template(contributorTemplate, contributor);
var rendered_template = _.template(contributorTemplate);
//console.log(rendered_template,contributor);

$(this.el).append(rendered_template);
$(this.el).append(rendered_template(contributor));
*/


Expand Down
4 changes: 2 additions & 2 deletions examples/modular-backbone/js/views/footer/FooterView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ define([
_: _
};

var compiledTemplate = _.template( footerTemplate, data );
this.$el.html(compiledTemplate);
var compiledTemplate = _.template( footerTemplate );
this.$el.html(compiledTemplate( data ));
}

});
Expand Down
4 changes: 2 additions & 2 deletions examples/modular-backbone/js/views/projects/ProjectsListView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ define([
_: _
};

var compiledTemplate = _.template( projectsListTemplate, data );
$("#projects-list").html( compiledTemplate );
var compiledTemplate = _.template( projectsListTemplate );
$("#projects-list").html( compiledTemplate( data ) );
}
});
return ProjectListView;
Expand Down
4 changes: 2 additions & 2 deletions examples/modular-backbone/js/views/sidebar/SidebarView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ define([
ads: [backbone_ad, require_ad]
};

var compiledTemplate = _.template( sidebarTemplate, data );
var compiledTemplate = _.template( sidebarTemplate );

$(".sidebar").append(compiledTemplate);
$(".sidebar").append(compiledTemplate( data ));
}

});
Expand Down