Add ssObject designation search across LSST and ZTF#1
Open
thomasculino wants to merge 1 commit into
Open
Conversation
|
Throughput results (
Baseline run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on boom-astro#497 and requires it to be merged before this one. In this one we aim to prepare the search on the frontend by ssObjectId. To do so, we:
Depends on # (lsst-ssobject-ingestion), which adds the designation field this builds on — base branch for this PR should be set to lsst-ssobject-ingestion, not main.
For ZTF, whether this method is the method we should use in the end is still uncertain. I'm open to suggestions.