Tweak formatting of input digest diffs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current formatting ends up looking like this: ``` bazel-out/k8-fastbuild/bin/path/to/file.tar.gz: hash: "b5b1169371c657146115147232068d1a04e88ca52df7de4f522bbc9fc3209606" size_bytes: 428915 hash_function_name: "SHA-256" hash: "747563ba65ac0f390ef1c983d189cdfeb6abb24c14b57ac34e9f101e6b847696" size_bytes: 428914 hash_function_name: "SHA-256" ``` I am hoping to make this more readable. With this change I think the format will end up looking more like this: ``` bazel-out/k8-fastbuild/bin/path/to/file.tar.gz: hash: "b5b1169371c657146115147232068d1a04e88ca52df7de4f522bbc9fc3209606" size_bytes: 428915 hash_function_name: "SHA-256" hash: "747563ba65ac0f390ef1c983d189cdfeb6abb24c14b57ac34e9f101e6b847696" size_bytes: 428914 hash_function_name: "SHA-256" ``` I think this could be taken a step further to collapse the hash and hash_function_name onto the same line like this: ``` bazel-out/k8-fastbuild/bin/path/to/file.tar.gz: SHA-256: "b5b1169371c657146115147232068d1a04e88ca52df7de4f522bbc9fc3209606" size_bytes: 428915 SHA-256: "747563ba65ac0f390ef1c983d189cdfeb6abb24c14b57ac34e9f101e6b847696" size_bytes: 428914 ``` But I'm not familiar with the shape of these digests so I didn't want to bake in any logic to do this if it doesn't always apply. This could also potentially be improved by producing a diff, like this: ```diff bazel-out/k8-fastbuild/bin/path/to/file.tar.gz: -SHA-256: "b5b1169371c657146115147232068d1a04e88ca52df7de4f522bbc9fc3209606" +SHA-256: "747563ba65ac0f390ef1c983d189cdfeb6abb24c14b57ac34e9f101e6b847696" -size_bytes: 428915 +size_bytes: 428914 ``` But I decided to keep this change relatively simple for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current formatting ends up looking like this:
I am hoping to make this more readable. With this change I think the
format will end up looking more like this:
I think this could be taken a step further to collapse the hash and
hash_function_name onto the same line like this:
But I'm not familiar with the shape of these digests so I didn't want to
bake in any logic to do this if it doesn't always apply.
This could also potentially be improved by producing a diff, like this:
But I decided to keep this change relatively simple for now.