Refactor: Centralized Regex Patterns and Type-Safe i18n Implementation#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a significant refactoring of the internal regex handling and internationalization (i18n) systems. I centralized all regular expressions into a dedicated package and replaced generic map-based translation data with structured types to enhance maintainability and runtime stability.
Key Changes
internal/regexpackage, consolidating patterns for Conventional Commits, SemVer, GitHub/Jira links, and Go modules. This eliminates redundantregexp.MustCompilecalls across the codebase.i18n.GetMessagemethod and its callers to use specificstructtypes instead ofmap[string]interface{}. This ensures that translation templates receive the correct fields at compile-time.ProgressDatastruct in the models package to replace generic maps inProgressEvent, providing a consistent schema for PR and commit generation feedback..mailmapfile and corrected repository casing in the version checker to match the canonical GitHub path.Technical Impact
GitHubClosedLinkandJiraTicketmakes it easier to update logic for different VCS or ticket providers in one place.