Skip to content

feat: Optimización de prompts AI y mejora de parsing JSON (#42) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomas-vilte merged 3 commits into from
Dec 14, 2025
Merged

feat: Optimización de prompts AI y mejora de parsing JSON (#42) #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef2d188
feat: enable JSON output for Gemini commit suggestions (#42)
thomas-vilte Dec 12, 2025
58ea791
feat: optimize AI prompts with JSON mode and improve acceptance crite…
thomas-vilte Dec 14, 2025
461f3e1
fix: ensure PR summarizer uses template for JSON format instructions
thomas-vilte Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions internal/cli/command/handler/suggestions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,24 +49,32 @@ func (h *SuggestionHandler) displaySuggestions(suggestions []models.CommitSugges
fmt.Printf(" - %s\n", file)
}
fmt.Printf("%s %s\n", h.t.GetMessage("gemini_service.explanation_prefix", 0, nil), suggestion.Explanation)
fmt.Println()

if suggestion.RequirementsAnalysis.CriteriaStatus != "" {
fmt.Printf("\n%s\n", h.t.GetMessage("gemini_service.requirements_analysis_prefix", 0, nil))
fmt.Printf("%s\n", h.t.GetMessage("gemini_service.requirements_analysis_prefix", 0, nil))
statusMsg := h.t.GetMessage("gemini_service.criteria_status_full", 0, map[string]interface{}{
"Status": h.getCriteriaStatusText(suggestion.RequirementsAnalysis.CriteriaStatus),
})
fmt.Printf("%s", statusMsg)
fmt.Printf("%s\n", statusMsg)
fmt.Println()

if len(suggestion.RequirementsAnalysis.MissingCriteria) > 0 {
fmt.Printf("\n%s", h.t.GetMessage("gemini_service.missing_criteria_prefix", 0, nil))
for _, criteria := range suggestion.RequirementsAnalysis.MissingCriteria {
fmt.Printf("\n - %s\n", criteria)
}
} else {
fmt.Println(h.t.GetMessage("gemini_service.missing_criteria_none", 0, nil))
}

if len(suggestion.RequirementsAnalysis.ImprovementSuggestions) > 0 {
fmt.Printf("\n%s", h.t.GetMessage("gemini_service.improvement_suggestions_prefix", 0, nil))
for _, improvement := range suggestion.RequirementsAnalysis.ImprovementSuggestions {
fmt.Printf("\n - %s", improvement)
}
fmt.Println()
}
} else {
fmt.Printf("\n%s\n", h.t.GetMessage("gemini_service.technical_analysis_section", 0, nil))
fmt.Printf("%s\n", h.t.GetMessage("gemini_service.technical_analysis_section", 0, nil))
if len(suggestion.RequirementsAnalysis.ImprovementSuggestions) > 0 {
fmt.Println(h.t.GetMessage("gemini_service.improvement_suggestions_label", 0, nil))
for _, improvement := range suggestion.RequirementsAnalysis.ImprovementSuggestions {
Expand Down
1 change: 1 addition & 0 deletions internal/domain/models/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ type Issue struct {
Labels []string
Author string
URL string
Criteria []string
}
10 changes: 5 additions & 5 deletions internal/i18n/locales/active.en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,18 @@ criteria_status_prefix = "⚠️ Criteria Status:"
missing_criteria_prefix = "❌ Missing Criteria:"
improvement_suggestions_prefix = "💡 Improvement Suggestions:"
improvement_suggestions_none = "-"
criteria_fully_met_prefix = "Fully Met"
criteria_partially_met_prefix = "Partially Met"
criteria_not_met_prefix = "Not Met"
criteria_unknown_prefix = "Unknown Status"
criteria_fully_met_prefix = "✅ Fully Met"
criteria_partially_met_prefix = "⚠️ Partially Met"
criteria_not_met_prefix = "❌ Not Met"
criteria_unknown_prefix = "❓ Unknown Status"
code_analysis_prefix = "📊 Code Analysis:"
changes_overview_prefix = "- Changes Overview:"
primary_purpose_prefix = "- Primary Purpose:"
technical_impact_prefix = "- Technical Impact:"
suggestion_prefix = "=========\\[ Suggestion\\s*\\d*\\s*\\]========="
technical_analysis_section = "💭 Technical Analysis:"
improvement_suggestions_label = "Suggested Improvements:"
criteria_status_full = "⚠️ Criteria Status: {{.Status}}"
criteria_status_full = "Criteria Status: {{.Status}}"
missing_criteria_none = "✅ Missing Criteria: None"
pr_title_section = "PR Title"
pr_labels_section = "Suggested Tags"
Expand Down
10 changes: 5 additions & 5 deletions internal/i18n/locales/active.es.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,15 @@ modified_files_prefix = "📄 Archivos modificados:"
explanation_prefix = "Explicación:"
requirements_analysis_prefix = "🎯 Análisis de Requerimientos:"
criteria_status_prefix = "⚠️ Estado de los Criterios:"
criteria_status_full = "⚠️ Estado de los Criterios: {{.Status}}"
criteria_status_full = "Estado de los Criterios: {{.Status}}"
missing_criteria_prefix = "❌ Criterios Faltantes:"
missing_criteria_none = "-"
improvement_suggestions_prefix = "💡 Sugerencias de Mejora:"
improvement_suggestions_none = "-"
criteria_fully_met_prefix = "Cumplimiento Completo"
criteria_partially_met_prefix = "Cumplimiento Parcial"
criteria_not_met_prefix = "No Cumplimiento"
criteria_unknown_prefix = "Estado Desconocido"
criteria_fully_met_prefix = "✅ Cumplimiento Completo"
criteria_partially_met_prefix = "⚠️ Cumplimiento Parcial"
criteria_not_met_prefix = "❌ No Cumplimiento"
criteria_unknown_prefix = "❓ Estado Desconocido"
code_analysis_prefix = "📊 Análisis de Código:"
changes_overview_prefix = "- Resumen de Cambios:"
primary_purpose_prefix = "- Propósito Principal:"
Expand Down
Loading
Loading