test: run on GitHub Actions #251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `t.fail` with the whole `Error` object, all keys are printed. When the `err` has a `stream` property or similar this can be massively noisy to the point of overflowing GHA's default max log length for viewing in the browser. While some error properties are useful (`stack`, `code`) this is the most straightforward way to cut the noise.
ljharb
reviewed
Sep 1, 2023
Comment on lines
+13
to
+19
| - uses: actions/checkout@v3 | ||
| - uses: dcodeIO/setup-node-nvm@v5 | ||
| with: | ||
| node-version: iojs | ||
| - run: npm install | ||
| - run: npm test | ||
| env: |
There was a problem hiding this comment.
i ended up wrapping dcodeIO's action in ljharb/actions/node/install, which I use on 400 projects for node versions ranging from 0.4 to latest. I also have ljharb/actions/node/matrix to easily and dynamically create a matrix. You can also use ljharb/actions/.github/workflows/node.yml to encapsulate all of this in a single swoop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Travis, whose OSS offering was killed by private equity, with GitHub Actions, so we actually have CI.