Get events from insight #6683
Get events from insight #6683
Conversation
🦋 Changeset detectedLatest commit: b6ba290 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
kumaryash90
added
the
DO NOT MERGE
github-actions
bot
added
packages
SDK
size-limit report 📦
|
kumaryash90
added
the
DO NOT MERGE
| } | ||
|
|
||
| const clientFetch = getClientFetch(client); | ||
| const result = await clientFetch(url.toString()); |
There was a problem hiding this comment.
should always check for error on response btw. and parse the error. will fix it when i switch to the autogen api though
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| throw new Error(result.error.error); | ||
| throw new Error( | ||
| `${result.response.status} ${result.response.statusText} - ${result.error ? stringify(result.error) : "Unknown error"}`, | ||
| ); | ||
| } | ||
| return result.data.data || []; |
There was a problem hiding this comment.
There's a potential null reference issue in this code. The expression result.data.data || [] will throw a TypeError if result.data is undefined.
This pattern is inconsistent with the other insight functions in get-nfts.ts and get-tokens.ts, which use the nullish coalescing operator with optional chaining: result.data?.data ?? [].
To prevent runtime errors when the API returns a response without a data property, consider updating this line to:
return result.data?.data ?? [];This change would make the error handling consistent across all insight functions and provide better resilience against unexpected API responses.
| return result.data.data || []; | |
| return result.data?.data ?? []; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
kumaryash90
removed
the
DO NOT MERGE
PR-Codex overview
This PR focuses on enhancing the
thirdweblibrary by introducing new features, improving error handling, and updating existing functionalities related to event fetching and chain services.Detailed summary
ChainServicetype totypes.ts..size-limit.json.getContractEventsmethod inget-events.tsfor fetching indexed events.getOwnedNFTsandgetOwnedTokens.useIndexerparameter for fetching events.getContractEventsto include indexer functionality.ready-tigers-pump.md.