Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-3314] Playground: Fix Next.js errors in Headless UI example pages #6175

Open
wants to merge 1 commit into
base: 02-05-_tool-3299_playground_update_sidebar_minor_improvements_and_fixes
Choose a base branch
from

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Feb 5, 2025

Fixed "Can not import server (async) components in client components" error


PR-Codex overview

This PR focuses on refactoring the wallet, NFT, token, and account components in the headless-ui section by creating specific preview components for better code organization and reusability.

Detailed summary

  • Created new preview components for WalletIcon, WalletName, and their formats in wallet-previews.tsx.
  • Introduced previews for NFT components like NftMedia, NftName, and NftDescription in nft-previews.tsx.
  • Added token previews for TokenIcon, TokenName, and TokenSymbol in token-previews.tsx.
  • Established account previews including AccountAddress, AccountAvatar, and AccountBalance in account-previews.tsx.
  • Updated example components to use the new preview components, enhancing readability and maintainability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Feb 5, 2025

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: bd2b883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Feb 5, 2025
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:51pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:51pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:51pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 5, 2025 4:51pm
wallet-ui ⬜️ Skipped (Inspect) Feb 5, 2025 4:51pm

@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 5, 2025 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 16:31 Inactive
@MananTank MananTank marked this pull request as ready for review February 5, 2025 16:31
@MananTank MananTank requested review from a team as code owners February 5, 2025 16:31
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (375b4b4) to head (bd2b883).

Additional details and impacted files
@@                                           Coverage Diff                                            @@
##           02-05-_tool-3299_playground_update_sidebar_minor_improvements_and_fixes    #6175   +/-   ##
========================================================================================================
  Coverage                                                                    56.92%   56.92%           
========================================================================================================
  Files                                                                         1155     1155           
  Lines                                                                        63923    63923           
  Branches                                                                      5194     5194           
========================================================================================================
  Hits                                                                         36391    36391           
  Misses                                                                       26803    26803           
  Partials                                                                       729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 375b4b4
packages 55.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 658 ms (+67.9% 🔺) 1.6 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 886 ms (-2.42% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 121 ms (+186.27% 🔺) 233 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (+38.82% 🔺) 23 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 212 ms (+223.07% 🔺) 598 ms

@MananTank MananTank force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from 2987f81 to 9e60b66 Compare February 5, 2025 16:35
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 5, 2025 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 16:35 Inactive
@MananTank MananTank force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from 9e60b66 to 296a627 Compare February 5, 2025 16:39
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 5, 2025
@MananTank MananTank force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from 296a627 to 766380e Compare February 5, 2025 16:43
@MananTank MananTank force-pushed the 02-05-_tool-3314_playground_fix_next.js_errors_in_headless_ui_example_pages branch from 766380e to bd2b883 Compare February 5, 2025 16:47
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 5, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 16:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants