Skip to content

WIP: MQTT/Websocket support for C8y #3575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jarhodes314
Copy link
Contributor

@jarhodes314 jarhodes314 commented Apr 23, 2025

Proposed changes

This was part of #3531 (and at the time of writing, is an exact copy of that), but I'm just creating a PR for this to make sure I can easily find the branch again so the websocket elements can be merged separately.

To enable websocket support, enable basic authentication, then run:

tedge config set c8y.bridge.protocol ws

You should get an error if websockets are enabled and you haven't configured basic auth.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 27.08333% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge_mapper/src/c8y/mapper.rs 0.00% 25 Missing ⚠️
...common/tedge_config/src/tedge_toml/tedge_config.rs 68.42% 0 Missing and 6 partials ⚠️
crates/extensions/tedge_mqtt_bridge/src/config.rs 0.00% 3 Missing ⚠️
.../common/tedge_config/src/tedge_toml/models/auto.rs 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant