V2 WIP - DO NOT MERGE #487
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert var → const/let across 13 core library files - Apply template literals for string concatenation - Modernize variable scoping in loops and functions - Add ES6_REFACTORING_PLAN.md documenting progress and next steps - Maintain backward compatibility with Node.js 4.x+ Core files refactored: - lib/WebSocketConnection.js (extensive class conversion) - lib/WebSocketClient.js, lib/WebSocketServer.js - lib/WebSocketFrame.js, lib/WebSocketRequest.js - lib/W3CWebSocket.js, lib/Deprecation.js - lib/utils.js, lib/websocket.js, lib/browser.js - example/whiteboard/whiteboard.js 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Refactor all unit tests (5 files) - var → const/let conversions - Refactor test infrastructure (2 files) - modern arrow functions and template literals - Refactor all test scripts (8 files) - comprehensive ES6 modernization - Fix linting issues in core library files: - Remove unused util import in WebSocketConnection.js - Fix const mutation in WebSocketRequest.js cookie parsing - Add JSHint global directive for globalThis in browser.js Test suite changes: - test/unit: dropBeforeAccept.js, regressions.js, request.js, w3cwebsocket.js, websocketFrame.js - test/shared: start-echo-server.js, test-server.js - test/scripts: autobahn-test-client.js, echo-server.js, fragmentation-test-client.js, fragmentation-test-server.js, libwebsockets-test-client.js, libwebsockets-test-server.js, memoryleak-client.js, memoryleak-server.js All 26 tests pass ✅ Linting passes without errors ✅ Maintains Node.js 4.x+ compatibility ✅ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Based on Gemini Code Assist review feedback, convert remaining anonymous function expressions to arrow functions for consistency across the test suite: - test/scripts/echo-server.js: Convert event handlers and callbacks - test/scripts/memoryleak-client.js: Convert connection event handlers - test/scripts/memoryleak-server.js: Convert server and connection callbacks - test/unit/: Convert all test callback functions and event handlers - test/shared/: Convert remaining server and process event handlers Maintains existing functionality while achieving consistent modern syntax. All 26 tests pass ✅ Linting passes ✅ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…e32/WebSocket-Node into phase1-test-suite-modernization
- Replace JSHint with ESLint for modern JavaScript linting - Remove gulp and use npm scripts for build tasks - Standardize codebase to 2-space indentation - Update package.json with new linting commands - Add comprehensive ESLint configuration for ES6+ support - Auto-format all files to consistent style - All tests continue to pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Convert remaining var declarations to const/let in WebSocketConnection.js, W3CWebSocket.js, and WebSocketClient.js - Fix ESLint case declaration issue with block scoping - Update ESLint configuration to handle legacy patterns and script files - Auto-format all files to consistent 2-space indentation - All tests continue to pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Removed .jshintrc configuration file - Updated package.json dependencies: replaced jshint packages with eslint - Updated gulpfile.js to use gulp-eslint instead of gulp-jshint - Converted all tab indentation to 2 spaces throughout codebase - Fixed remaining ESLint issues including multiline function calls - Updated CLAUDE.md coding style guide to reflect 2-space indentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Update ES6_REFACTORING_PLAN.md to reflect completion of Phase 1. All 15 test files have been successfully modernized with: - var → const/let conversions throughout - Arrow functions for callbacks and handlers - Template literals for string interpolation - Modern ES6+ patterns consistently applied Phase 1 is now 100% complete and ready for Phase 2. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove gulp and gulp-eslint dependencies - Add lint and lint:fix npm scripts using ESLint directly - Update GitHub Actions workflow to run npm run lint - Update CLAUDE.md documentation with new commands - Remove gulpfile.js as it's no longer needed 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Phase 1: Complete test suite modernization with ES6 patterns
This commit implements the first three components of Phase 2 ES6+ modernization: ## 1. Enhanced Template Literals - Converted string concatenations to template literals across all lib/ files - Improved readability of error messages and HTTP response building - Updated complex multi-line concatenations in WebSocketClient.js and WebSocketRequest.js - Replaced debug/logging string concatenations in WebSocketFrame.js ## 2. Arrow Functions - Converted appropriate function expressions to arrow functions - Updated forEach callbacks, event handlers, and utility functions - Improved code conciseness while maintaining proper `this` binding - Updated functions in WebSocketServer.js, WebSocketClient.js, WebSocketRequest.js, and utils.js ## 3. Destructuring - Simplified object property extraction patterns - Added destructuring for constructor property assignments - Implemented array destructuring for frame header parsing - Reduced repetitive property access in WebSocketRouterRequest.js and other files ## Testing - All existing tests pass (30/30) - No linting errors - Maintains backward compatibility with Node.js 4.x+ - No breaking changes to public APIs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Update Node.js version from 10.x to 18.x in GitHub Actions workflow to resolve ESLint 8.x compatibility issue. ESLint 8.x requires Node.js 12+ but the workflow was using Node.js 10.x, causing "Module.createRequire is not a function" error. Changes: - Update actions/setup-node from v1 to v3 - Update node-version from 10.x to 18.x - Keep ESLint at ^8.0.0 for modern linting features 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Address Gemini Code Assist review feedback by fixing reverted ES6+ features:
## WebSocketClient.js
- Restore arrow function for req.on('response') callback
- Restore destructuring for response headers extraction
- Restore const and template literals for SHA1 key generation
## WebSocketConnection.js
- Restore arrow functions for process.nextTick callbacks
- Update self references to this (arrow functions preserve lexical this)
- Maintain consistent ES6+ modernization
## WebSocketRequest.js
- Restore destructuring for httpRequest extraction
- Restore const declaration for protocolString
## Testing
- All tests pass (30/30)
- No linting errors
- Maintains backward compatibility
These changes restore the intended ES6+ modernizations that were
accidentally reverted, addressing the specific review feedback.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Parses test/autobahn/reports/servers/index.json - Provides comprehensive test result summary - Groups and categorizes different test outcomes (OK, Failed, Non-Strict, Informational, Unimplemented) - Executable script for easy test result analysis - Confirms ES6+ modernization hasn't broken WebSocket protocol compliance 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Comprehensive Node.js script that orchestrates full test workflow - Automatically starts echo server in background - Runs Autobahn WebSocket test suite via Docker - Gracefully shuts down echo server when tests complete - Parses and displays detailed test results - Handles process cleanup and error recovery - Replaces manual bash script with automated solution - Provides clear progress indicators and status updates Features: - Automatic port conflict detection - Graceful process termination handling - Progress indicators during test execution - Integrated results parsing and display - Comprehensive error handling and cleanup 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added npm script "test:autobahn" for running comprehensive WebSocket protocol compliance tests - Script runs the automated Autobahn test runner from test/autobahn directory - Developers can now run "npm run test:autobahn" for full protocol validation - Integrates WebSocket compliance testing into standard npm workflow 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ow-functions-destructuring Phase 2: Template Literals, Arrow Functions, and Destructuring
- Mark Enhanced Template Literals as completed ✅ - Mark Arrow Functions as completed ✅ - Mark Destructuring as completed ✅ - Update Phase 2 status to IN PROGRESS 🔄 - Document all files modified in Phase 2 - Record validation completed (unit tests, ESLint, Autobahn tests) - Added new Autobahn test infrastructure to completed tasks - Ready for remaining Phase 2 tasks: Default Parameters and Object Literal Enhancements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Default Parameters: - WebSocketConnection.close(): reasonCode defaults to CLOSE_REASON_NORMAL - WebSocketConnection.drop(): reasonCode defaults to CLOSE_REASON_PROTOCOL_ERROR - WebSocketConnection.sendCloseFrame(): reasonCode defaults to CLOSE_REASON_NORMAL - WebSocketRequest.reject(): status defaults to 403 - WebSocketClient.connect(): protocols defaults to [] - BufferingLogger.printOutput(): logFunction defaults to this.logFunction Object Literal Enhancements: - WebSocketRequest.parseCookies(): Use shorthand for name property in cookie objects - WebSocketRouter.mount(): Use shorthand for path, pathString, protocol, callback properties - browser.js: Use shorthand for version property in module.exports - Deprecation.js: Use shorthand method syntax for warn method - W3CWebSocket.js: Use shorthand method syntax for all getter/setter methods - WebSocketClient.connect(): Use shorthand for hostname, port, method, path properties All changes maintain backward compatibility and improve code readability Tests pass ✅ | ESLint passes ✅ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Mark Phase 2 as COMPLETED with all 5 tasks finished - Add Default Parameters and Object Literal Enhancements to completed tasks - Update file modification list with new features applied - Add Phase 2 completion summary with metrics: * 11 core library files modernized * 6 default parameters implemented * 8 files enhanced with object shorthand syntax * Zero breaking changes * Pull Request #466 created - Ready for Phase 3 (Optional Advanced Features) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ject-literals Phase 2: Default Parameters and Object Literal Enhancements
- Re-enable no-empty and no-unsafe-finally rules for better code quality - Add targeted local disablements in lib/browser.js for legitimate cases: - Empty catch block in global detection fallback (line 9) - Throw in finally block for critical error handling (line 13) - Maintains strict linting while allowing necessary patterns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add validation for empty or invalid JSON results files - Prevents TypeError when Object.keys(results) returns empty array - Addresses Gemini Code Assist review feedback - Provides clear error message for empty results files Resolves code review issue: handle edge case where Autobahn results file exists but contains empty JSON object. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
* Add cross-platform support for Autobahn test suite This commit enables the Autobahn WebSocket protocol compliance test suite to run on both Docker Desktop (Mac/Windows) and Docker-in-Docker (Linux) environments. Changes: - Auto-detect platform and use appropriate Docker networking - Mac/Windows: Uses host.docker.internal with port mapping - Linux: Uses --network=host with localhost - Add fuzzingclient-linux.json config for Linux environments - Add DOCKER_AUTOBAHN_SETUP.md with installation instructions Test Results (517 total tests): - ✅ 294 passed (56.9%) - ✅ 0 failed - 📝 4 non-strict (acceptable deviations) - 📝 3 informational (expected behavior) - 📝 216 unimplemented (optional compression extensions) All core RFC 6455 protocol tests pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Remove obsolete DOCKER_AUTOBAHN_SETUP.md This file was created for native Python installation instructions, but is no longer needed since we're using Docker-in-Docker. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Add Autobahn protocol tests to GitHub Actions workflow The workflow now runs the comprehensive Autobahn WebSocket protocol compliance test suite (517 tests) in addition to the existing unit tests. Changes: - Pull crossbario/autobahn-testsuite Docker image - Run full Autobahn test suite via run-wstest.js - Tests will fail CI if any protocol compliance issues are detected The parse-results.js script exits with code 1 on test failures, which will cause the GitHub Actions workflow to fail appropriately. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Fix exit code handling for Autobahn test failures The test runner was intercepting process.exit() but not properly propagating failure exit codes, causing CI to pass even with test failures. Changes: - parse-results.js: Return summary object for programmatic access - run-wstest.js: Capture exit code and check summary.failed - Exit with code 1 if there are any test failures - Exit with code 1 if results file is missing Tested with mock results: - ✅ Exit code 1 with failures - ✅ Exit code 0 with all passing This ensures GitHub Actions CI will fail appropriately when protocol compliance tests fail. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Improve pass rate calculation to exclude unimplemented tests Previously the pass rate included unimplemented tests (optional WebSocket extensions) in the denominator, showing 56.9% (294/517). This was misleading since unimplemented extensions are not failures. Changes: - Show both 'Total tests' and 'Implemented tests' counts - Calculate pass rate based only on implemented tests - Label as 'Pass rate (implemented)' for clarity Results with current implementation: - Before: 56.9% (294/517 including unimplemented) - After: 97.7% (294/301 excluding unimplemented) This gives a more accurate representation of protocol compliance for the implemented features. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Clarify test output: required vs optional protocol features Updated terminology to accurately reflect that unimplemented tests are for optional WebSocket protocol features (like compression extensions), not missing implementation of required features. Changes: - 'Implemented tests' → 'Required tests' - Added 'Optional tests' line to show count clearly - 'Pass rate (implemented)' → 'Pass rate (required)' - 'UNIMPLEMENTED TESTS' → 'OPTIONAL FEATURES NOT IMPLEMENTED' Example output: Total tests: 517 Required tests: 301 Optional tests: 216 Pass rate (required): 97.7% This makes it clear that 97.7% of required protocol functionality passes, and 216 tests are for optional extensions not implemented. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Exclude non-strict and informational tests from pass rate Non-strict and informational tests are not failures, they represent acceptable behavior variations, so they should not count against the pass rate. Changes: - Pass rate now excludes: optional + non-strict + informational tests - Simplified label from 'Pass rate (required)' to 'Pass rate' - Pass rate now shows actual pass/fail ratio for strict tests Example with current implementation: - Before: 97.7% (294 / 301) - After: 100.0% (294 / 294) Calculation: OK / (Total - Optional - Non-Strict - Informational) = 294 / (517 - 216 - 4 - 3) = 294 / 294 = 100% This accurately reflects that all strict required tests pass with zero failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
All Gemini code review feedback addressed: - HIGH: Added try-finally for environment cleanup in BufferingLogger test - MEDIUM: Refactored separator test to use it.each (improved from 616 to 632 tests) - MEDIUM: Fixed EventEmitter imports All 632 tests passing ✅ All 517 Autobahn tests passing ✅ CI checks passed ✅
* Add Playwright browser testing infrastructure Set up Playwright for browser-based WebSocket testing with: - Express-based test server with echo protocol support - Interactive HTML test page with WebSocket client UI - 12 comprehensive browser tests for real WebSocket connections - Support for Chromium, Firefox, and WebKit browsers - Auto-start/stop test server via webServer configuration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Address Gemini code review feedback - Fix binary data logging bug: Use byteLength for ArrayBuffer - Enable server stdout piping for better test debugging - Remove waitForTimeout to avoid test flakiness 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
Phase 5.1 Browser Compatibility marked as complete with: - 12 Playwright browser tests implemented - Express-based WebSocket test server - Interactive HTML test page - Support for Chromium, Firefox, WebKit Overall progress: 85% → 88% Total tests: 1,133 → 1,145 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
* Add multi-version Node.js testing to CI Configure GitHub Actions to test on multiple Node.js versions: - Node.js 16.x (EOL but still in use) - Node.js 18.x (LTS) - Node.js 20.x (LTS) - Node.js 22.x (Current) Additional improvements: - Add browser tests to CI pipeline - Set fail-fast: false to test all versions - Add descriptive step names 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Fix CI: Install Playwright browsers before running tests * Remove browser tests from multi-version CI workflow Focus on Node.js compatibility matrix testing only. Browser tests can be added to CI in a separate workflow later. * Remove Node.js 16.x from CI matrix Node.js 16.x reached EOL in September 2023 and Vitest/Vite no longer support it (crypto.getRandomValues compatibility issue). Testing on actively supported LTS versions: - Node.js 18.x (Active LTS) - Node.js 20.x (Active LTS) - Node.js 22.x (Current) --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
Phase 6.4 Multi-Version Testing marked as complete: - Node.js 18.x, 20.x, 22.x all passing - Parallel matrix execution in CI - All 628 tests + 517 Autobahn tests per version Overall progress: 88% → 91% Phase 6 completion: 50% → 75% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
* Add performance benchmark suite Implements Phase 6.3 Performance Regression Detection with: - Frame serialization benchmarks (4M+ ops/sec) - Connection operations benchmarks (25-35K ops/sec) - Vitest bench infrastructure with dedicated config - README documentation for benchmark interpretation Benchmarks cover: - Small text frames (17 bytes) - Medium binary frames (1KB) - Large binary frames (64KB) - Connection lifecycle and message sending - Ping/Pong frames 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Add performance baseline tracking and regression detection - Automated baseline save/compare script - 15% regression threshold for CI failures - npm scripts for baseline management - Initial performance baseline saved Commands: - pnpm bench:baseline - Save current perf as baseline - pnpm bench:check - Check for regressions (exits 1 if found) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Add GitHub Actions workflow for performance benchmarks - Runs benchmarks on PRs that modify lib/ or benchmarks - Manual workflow_dispatch trigger available - Regression check is informational (warning only) - Uses Node.js 20.x for consistent results 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
* Add performance metrics tracking to Autobahn test parser Enhance parse-results.js to capture and display timing data: - Track total test duration and per-test averages - Categorize performance-focused tests (9.x limits, 10.x large messages, 12.x fragmentation) - Display category breakdowns with average durations - Show top 5 slowest tests per performance category Performance summary now shows: - 9.x (Limits/Performance): 54 tests, avg 175.56ms - 10.x (Large Messages): 1 test, avg 7.00ms - 12.x (Fragmentation): 90 tests, avg 1.23ms 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Address Gemini code review feedback Fix high priority issues: - Prevent array mutation by copying before sorting (line 204) Fix medium priority issues: - Use map object for cleaner category mapping (lines 51-55, 109) - Rename 'case' property to 'testCase' to avoid reserved keyword (lines 112, 210) - Dynamically generate performance categories from object keys (line 189) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
Modified Autobahn test runners to dynamically inject current commit SHA into test agent identifier instead of hardcoded version number. Changes: - run-wstest.js: Generate temp config with commit SHA, fallback to 'unknown' - run-wstest.sh: Use sed to inject commit SHA, fallback to 'unknown' - Clean up temp config files after test completion - Updated TEST_SUITE_MODERNIZATION_PLAN.md with completed Phase 6.3 Test agent format: "WebSocket-Node@<short-sha>" (e.g., "WebSocket-Node@bf428ef") 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
* Address Gemini code review comments on PR #494 High Priority: - Separate setup logic from measured operations in connection benchmarks - Create shared connection once, reuse across all benchmark iterations - Dramatically improved benchmark accuracy (2.4M ops/sec for ping vs 33K before) Medium Priority: - Lazily initialize suite results in track-performance.mjs to prevent empty entries - Remove redundant test.include from vitest.bench.config.mjs - Add bench:compare script to package.json to match README documentation Updated baseline.json with new accurate performance measurements: - Connection operations now measure actual send performance (not setup) - Frame serialization remains consistent at 4M+ ops/sec - Ping/pong operations: 2.4M / 1.9M ops/sec (previously 33K) - Message sending: 900K / 220K / 108K ops/sec (previously 25-28K) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Add explanation for not using beforeAll in benchmarks Vitest's benchmark runner doesn't execute hooks (beforeAll/beforeEach) before benchmarks in the same way as test(). Direct initialization at module scope ensures the shared connection is available when benchmarks run. Attempted using beforeAll() but it resulted in 0 hz for all benchmarks using sharedConnection, indicating the hook wasn't executed before benchmark iterations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
Modified performance workflow to: - Capture benchmark output to file - Parse results for both WebSocketConnection and WebSocketFrame operations - Display formatted tables in GitHub Actions summary with ops/sec, mean, and p99 metrics - Always show summary even if benchmarks fail The summary will display: - WebSocketConnection Performance table (6 operations) - WebSocketFrame Performance table (4 operations) - Timestamp of benchmark run 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replaced complex awk parsing with simple markdown code block containing raw benchmark output. Much simpler and easier to maintain. Note: Vitest has --outputJson flag for structured benchmark output, which could be used in the future for programmatic comparison. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Benchmark Restructuring: - Put each operation in its own describe() block to prevent Vitest from treating them as alternatives for comparison - Eliminates confusing "X times faster than Y" comparisons between unrelated operations (e.g., ping vs connection creation) - Each benchmark now measured independently Simplified Comparison Logic: - Replaced custom track-performance.mjs with Vitest's built-in --outputJson and --compare flags - Vitest natively shows ⇑/⇓ indicators and multipliers for changes - Baseline stored in standard Vitest JSON format - Updated scripts: - bench:baseline - Save results to baseline.json - bench:compare - Compare with baseline - bench:check - Check for regressions (CI mode) Updated Documentation: - Added benchmark structure explanation - Documented Vitest's comparison output format - Updated expected performance ranges 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Use 'pnpm run bench --' in bench:baseline and bench:compare to avoid duplicating full command - Add note explaining bench:check is intended for CI environments where builds should fail on performance regressions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Restructure benchmarks and use Vitest's native comparison
Use sed to remove ANSI escape sequences (color/formatting codes) before appending benchmark results to the GitHub Actions summary, ensuring clean, readable output without terminal control characters. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Parse JSON output with jq to create formatted markdown table - Add thousand separators to operations/sec column - Convert time values from seconds to milliseconds - Include both markdown table and raw terminal output - Terminal output still has ANSI codes stripped 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Values are already in milliseconds, removed incorrect *1000 multiplication - Reordered columns to match ASCII output: Hz, Min, Max, Mean, P75, P99, P995, P999 - Fixed thousands separator to handle large numbers correctly (e.g., 4,198,728) - Uses recursive add_commas function instead of regex 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Created scripts/format-benchmarks.mjs to parse JSON and generate markdown - Simplified GitHub Actions workflow to call the script - Script is easier to test locally and maintain - Maintains same output format: table with Hz, Min, Max, Mean, P75, P99, P995, P999 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updated formatNumber function to round to 4 decimal places instead of 2, providing more precise timing measurements for fast operations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Strip ANSI control codes from benchmark output in GitHub Actions summary
- Configure GitHub Actions to generate and upload coverage reports - Add codecov.yml with 85% project target and 80% patch target - Add Codecov badge to README - Upload coverage only on Node.js 20.x to avoid duplicates - Configure coverage thresholds: 85% for project, 80% for patches - Add PR coverage diff comments via Codecov 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Updated Codecov badge alt text to "code coverage" for accessibility - Set require_changes: yes to reduce PR comment noise - Added lib/version.js to ignore list for consistency with vitest config - Updated codecov-action from v4 to v5 per Codecov documentation - Simplified codecov-action configuration (v5 auto-detects coverage files) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Node.js 18.x and 20.x: Run tests without coverage - Node.js 22.x: Run tests with coverage and upload to Codecov - Avoids running tests twice on the same version 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add Codecov integration for coverage reporting
- Marked Phase 6.2 (Coverage Reporting) as complete - Updated overall progress from 91% to 95% - Updated Phase 6 from 75% to 100% complete - Added Codecov integration details and files - Updated Quick Reference with Phase 6 completion status Phase 6 is now 100% complete: - ✅ 6.1 GitHub Actions CI Pipeline - ✅ 6.2 Coverage Reporting (Codecov) - ✅ 6.3 Performance Regression Detection - ✅ 6.4 Multi-Version Testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update test plan: Phase 6.2 Coverage Reporting complete
Create detailed status report documenting project completion at 95%, with all core objectives achieved. Report includes: - Complete test coverage analysis (85.05%, target achieved) - All 1,161 tests passing (unit, integration, browser, Autobahn) - Comprehensive component-by-component status breakdown - Recent accomplishments and CI/CD integration details - Release readiness assessment with no blockers identified - Recommendations for release preparation and future development This report serves as a snapshot of the v2 project state as of Oct 6, 2025 and confirms readiness to proceed with release preparation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Correct documentation to reflect actual ES6+ features used: - Nullish coalescing assignment (??=) requires Node.js 15+ - Object.entries() requires Node.js 7+ - Default parameters require Node.js 6+ - Spread operators require Node.js 5+ Updated files: - package.json: engines.node ">=18.0.0" - V2_RELEASE_READINESS_REPORT.md: Remove Node.js 4.x compatibility claim - V2_MODERNIZATION_STATUS.md: Add Node.js compatibility notes - CLAUDE.md: Update coding style guide All 632 tests passing with Node.js 18.x, 20.x, 22.x in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
* Suppress debug output during test runs Clean up test output by preventing debug logging from cluttering test results while maintaining full debug functionality in production. Changes: - WebSocketConnection: Only call printOutput() in non-test environments - test/shared/setup.mjs: Disable debug module by default during tests - test/unit/core/utils.test.mjs: Properly cleanup debug state in afterEach - test/unit/core/utils-enhanced.test.mjs: Fix test assertions and cleanup - vitest.config.mjs: Add reporter configuration Benefits: - Clean, readable test output without debug noise - Maintains full debug functionality in production - Tests that specifically need debug can enable it explicitly - All 632 tests passing with zero debug output Before: Tests showed verbose socket events, errors, and debug messages After: Clean test output showing only test results 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Address Gemini code review comments Improvements based on Gemini's medium-priority feedback: 1. Centralize debug module imports: - test/shared/setup.mjs: Use import at top instead of require in hooks - test/unit/core/utils.test.mjs: Add import debug at top, reuse in hooks - test/unit/core/utils-enhanced.test.mjs: Add import debug at top, reuse in hooks 2. Clean up redundant configuration: - vitest.config.mjs: Remove redundant silent and reporters defaults Benefits: - Consistent ES module import style across all test files - DRY principle - import once, reuse throughout the file - Cleaner vitest configuration without unnecessary defaults All 632 tests still passing with zero debug output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude Code <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.