Open
Conversation
yulian172
commented
Dec 17, 2020
| "github.com/tokopedia/tokopoints/tracer" | ||
| ) | ||
|
|
||
| func GetNilaiSiswa(ctx context.Context, nim int64, sekolah, kelas string, mapel_id int64) (resp GetNilaiSiswaResponse, err error) { |
Author
There was a problem hiding this comment.
parameter nya bisa pake struct NilaiSiswa biar lebih dikit
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) |
Author
There was a problem hiding this comment.
bisa dicek dulu length dari nilai.Sekolah harus > 0
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | ||
| } else if sekolah != "semua" { |
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | ||
| } else if sekolah == "semua" { |
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) |
Author
There was a problem hiding this comment.
bisa dicek dulu length dari nilai.Sekolah harus > 0
| func (s *server) GetNilaiSiswa(ctx context.Context, req *pb.GetNilaiSiswaRequest) (resp *pb.GetNilaiSiswaResponse, err error) { | ||
|
|
||
| if req.sekolah == "" { | ||
| req.sekolah = "semua" |
| var err error | ||
| db, err = database.Get(database.PromoCatalog) | ||
| if err != nil { | ||
| log.Printf("Cannot connect to DB. %+v", err) |
Author
There was a problem hiding this comment.
mungkin bisa diganti pake log.Fatal
Comment on lines
+24
to
+26
| QueryGetNilaiSiswaByID = `select nim, mapel_id, nilai, sekolah, kelas | ||
| from nilai_siswa | ||
| where mapel_id = $1 and nim = $2;` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.