Open
Conversation
fsetiawan29
commented
Dec 17, 2020
| type NilaiSiswa struct { | ||
| NIM int64 `json:"nim" db:"nim"` | ||
| MapelID int64 `json:"mapel_id" db:"mapel_id"` | ||
| Nilai int64 `json:"nili" db:"nili"` |
Author
There was a problem hiding this comment.
Suggested change
| Nilai int64 `json:"nili" db:"nili"` | |
| Nilai int64 `json:"nilai" db:"nilai"` |
| Kelas string `json:"kelas" db:"kelas"` | ||
| } | ||
|
|
||
| func GetNilaiSiswaByID(ctx context.Context, nim, mapel_id int64) (result []NilaiSiswa, err error) { |
Author
There was a problem hiding this comment.
disarankan pakai camel case ya jd bisa mapelID
Suggested change
| func GetNilaiSiswaByID(ctx context.Context, nim, mapel_id int64) (result []NilaiSiswa, err error) { | |
| func GetNilaiSiswaByID(ctx context.Context, nim, mapelID int64) (result []NilaiSiswa, err error) { |
|
|
||
| func (s *server) GetNilaiSiswa(ctx context.Context, req *pb.GetNilaiSiswaRequest) (resp *pb.GetNilaiSiswaResponse, err error) { | ||
|
|
||
| if req.sekolah == "" { |
Author
There was a problem hiding this comment.
krn req itu pointer, lebih enak kalau di cek dia nilai atau ga ya
Author
There was a problem hiding this comment.
di cek nil atau ga maksudnya hehe
| "github.com/tokopedia/tokopoints/tracer" | ||
| ) | ||
|
|
||
| func GetNilaiSiswa(ctx context.Context, nim int64, sekolah, kelas string, mapel_id int64) (resp GetNilaiSiswaResponse, err error) { |
Author
There was a problem hiding this comment.
kindly reminder buat mapel_id diubah jd mapelID ya
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) |
Author
There was a problem hiding this comment.
mungkin bisa di cek length dari nilai.Sekolah ya takut panic pas get index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.