Open
Conversation
ibnufirdaus
commented
Dec 17, 2020
| type NilaiSiswa struct { | ||
| NIM int64 `json:"nim" db:"nim"` | ||
| MapelID int64 `json:"mapel_id" db:"mapel_id"` | ||
| Nilai int64 `json:"nili" db:"nili"` |
Author
There was a problem hiding this comment.
Suggested change
| Nilai int64 `json:"nili" db:"nili"` | |
| Nilai int64 `json:"nilai" db:"nilai"` |
typo
Comment on lines
+15
to
+54
| if nim != 0 && mapel_id != 0 { | ||
| nilai, err := nilai.GetNilaiSiswaByID(ctx, nim, mapel_id) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | ||
| } else if sekolah != "semua" { | ||
| nilai, err := nilai.GetNilaiSiswaBySekolah(ctx, sekolah) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | ||
| } else if sekolah == "semua" { | ||
| nilai, err := nilai.GetNilaiSiswaSemuaSekolah(ctx) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | ||
| } | ||
|
|
||
| return resp, nil | ||
| } |
Author
There was a problem hiding this comment.
Suggested change
| if nim != 0 && mapel_id != 0 { | |
| nilai, err := nilai.GetNilaiSiswaByID(ctx, nim, mapel_id) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | |
| } else if sekolah != "semua" { | |
| nilai, err := nilai.GetNilaiSiswaBySekolah(ctx, sekolah) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | |
| } else if sekolah == "semua" { | |
| nilai, err := nilai.GetNilaiSiswaSemuaSekolah(ctx) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | |
| } | |
| return resp, nil | |
| } | |
| if nim != 0 && mapel_id != 0 { | |
| nilai, err := nilai.GetNilaiSiswaByID(ctx, nim, mapel_id) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| } else if sekolah != "semua" { | |
| nilai, err := nilai.GetNilaiSiswaBySekolah(ctx, sekolah) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| } else if sekolah == "semua" { | |
| nilai, err := nilai.GetNilaiSiswaSemuaSekolah(ctx) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| } | |
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | |
| if err != nil { | |
| return resp, errors.AddTrace(err) | |
| } | |
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | |
| return resp, nil | |
| } |
ada code duplication, bisa digabung jadi satu diakhir fungsi sebelum return
| "github.com/tokopedia/tokopoints/tracer" | ||
| ) | ||
|
|
||
| func GetNilaiSiswa(ctx context.Context, nim int64, sekolah, kelas string, mapel_id int64) (resp GetNilaiSiswaResponse, err error) { |
Author
There was a problem hiding this comment.
request param bisa dikumpulin jadi satu request struct, biar lebih rapi dan kalo ada changes ga ubah2 susunan param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.