Open
Conversation
natasharamdani
commented
Dec 17, 2020
| var ( | ||
| db *sqlt.DB | ||
| stmt PreparedStatements | ||
| redis *redislib.RedisStore // redis module |
Author
There was a problem hiding this comment.
Suggested change
| redis *redislib.RedisStore // redis module | |
| redis *redislib.RedisStore |
remove unnecessary comment
natasharamdani
commented
Dec 17, 2020
| ) | ||
|
|
||
| const ( | ||
| // Collection queries |
Author
There was a problem hiding this comment.
Suggested change
| // Collection queries | |
| // Nilai Siswa queries |
natasharamdani
commented
Dec 17, 2020
Comment on lines
+24
to
+26
| QueryGetNilaiSiswaByID = `select nim, mapel_id, nilai, sekolah, kelas | ||
| from nilai_siswa | ||
| where mapel_id = $1 and nim = $2;` |
Author
There was a problem hiding this comment.
Suggested change
| QueryGetNilaiSiswaByID = `select nim, mapel_id, nilai, sekolah, kelas | |
| from nilai_siswa | |
| where mapel_id = $1 and nim = $2;` | |
| QueryGetNilaiSiswaByMapelIDAndNIM = ` | |
| SELECT nim, mapel_id, nilai, sekolah, kelas | |
| FROM nilai_siswa | |
| WHERE mapel_id = $1 AND nim = $2; | |
| ` |
natasharamdani
commented
Dec 17, 2020
|
|
||
| type NilaiSiswa struct { | ||
| NIM int64 `json:"nim" db:"nim"` | ||
| MapelID int64 `json:"mapel_id" db:"mapel_id"` |
Author
There was a problem hiding this comment.
Suggested change
| MapelID int64 `json:"mapel_id" db:"mapel_id"` | |
| MapelID int `json:"mapel_id" db:"mapel_id"` |
sepertinya data type int64 terlalu berlebihan untuk mata pelajaran
natasharamdani
commented
Dec 17, 2020
| type NilaiSiswa struct { | ||
| NIM int64 `json:"nim" db:"nim"` | ||
| MapelID int64 `json:"mapel_id" db:"mapel_id"` | ||
| Nilai int64 `json:"nili" db:"nili"` |
Author
There was a problem hiding this comment.
Suggested change
| Nilai int64 `json:"nili" db:"nili"` | |
| Nilai float32 `json:"nilai" db:"nilai"` |
nilai biasanya ada angka di belakang koma
natasharamdani
commented
Dec 17, 2020
| ) | ||
|
|
||
| func (s *server) GetNilaiSiswa(ctx context.Context, req *pb.GetNilaiSiswaRequest) (resp *pb.GetNilaiSiswaResponse, err error) { | ||
|
|
Author
There was a problem hiding this comment.
Suggested change
| span, ctx := tracer.StartSpanFromContext(ctx) | |
| defer span.Finish() | |
natasharamdani
commented
Dec 17, 2020
| func (s *server) GetNilaiSiswa(ctx context.Context, req *pb.GetNilaiSiswaRequest) (resp *pb.GetNilaiSiswaResponse, err error) { | ||
|
|
||
| if req.sekolah == "" { | ||
| req.sekolah = "semua" |
Author
There was a problem hiding this comment.
untuk string "semua" mungkin bisa dibuat const
natasharamdani
commented
Dec 17, 2020
| req.sekolah = "semua" | ||
| } | ||
|
|
||
| nilai, err := mnilai.GetNilaiSiswa(req.nim, req.sekolah, req.kelas, mapel_id) |
Author
There was a problem hiding this comment.
Suggested change
| nilai, err := mnilai.GetNilaiSiswa(req.nim, req.sekolah, req.kelas, mapel_id) | |
| nilai, err := mnilai.GetNilaiSiswa(req.nim, req.sekolah, req.kelas, req.mapel_id) |
natasharamdani
commented
Dec 17, 2020
Comment on lines
+7
to
+9
| "github.com/tokopedia/code-review-workshop/database" | ||
| redislib "github.com/tokopedia/code-review-workshop/redis" | ||
| "github.com/tokopedia/sqlt" |
Author
There was a problem hiding this comment.
import beda repo sebaiknya dipisah dengan newline
natasharamdani
commented
Dec 17, 2020
Comment on lines
+6
to
+8
| nilai "github.com/tokopedia/code-review-workshop/core/nilai" | ||
| "github.com/tokopedia/tokopoints/errors" | ||
| "github.com/tokopedia/tokopoints/tracer" |
Author
There was a problem hiding this comment.
import beda repo sebaiknya dipisah dengan newline
natasharamdani
commented
Dec 17, 2020
| span, ctx := tracer.StartSpanFromContext(ctx) | ||
| defer span.Finish() | ||
|
|
||
| if nim != 0 && mapel_id != 0 { |
Author
There was a problem hiding this comment.
Suggested change
| if nim != 0 && mapel_id != 0 { | |
| if nim > 0 && mapel_id > 0 { |
antisipasi negative value
natasharamdani
commented
Dec 17, 2020
Comment on lines
+33
to
+38
| detailSekolah, err := nilai.GetDetailSekolah(ctx, nilai.Sekolah[0]) | ||
| if err != nil { | ||
| return resp, errors.AddTrace(err) | ||
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) |
Author
There was a problem hiding this comment.
GetDetailSekolah dan mappingGetNilaiSiswa lebih baik setelah if else selesai agar tidak redundant
natasharamdani
commented
Dec 17, 2020
| } | ||
|
|
||
| resp = mappingGetNilaiSiswa(nilai, detailSekolah) | ||
| } else if sekolah == "semua" { |
Author
There was a problem hiding this comment.
Suggested change
| } else if sekolah == "semua" { | |
| } else { |
natasharamdani
commented
Dec 17, 2020
| "github.com/tokopedia/tokopoints/tracer" | ||
| ) | ||
|
|
||
| func GetNilaiSiswa(ctx context.Context, nim int64, sekolah, kelas string, mapel_id int64) (resp GetNilaiSiswaResponse, err error) { |
Author
There was a problem hiding this comment.
param pakai struct supaya lebih rapi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.