fix: authorization code error should be redirect #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Mar 3, 2025
| // | ||
| // so if redirectUri is not already set, we try to set request redirect_uri params, fallback to first redirectUri of client | ||
| /** @psalm-suppress RiskyTruthyFalsyComparison !empty($e->getHint()),empty($e->getRedirectUri()) we really want to check null and empty */ | ||
| if (!empty($client) |
There was a problem hiding this comment.
please use explicit checks instead of empty()
There was a problem hiding this comment.
explicit checks now used on $client
There was a problem hiding this comment.
Sorry, I meant everywhere in the patch. I try to avoid using empty() for the reasons mentioned here.
There was a problem hiding this comment.
ok no problem, I understand
new commit pushed
|
I just pushed a new commit to fix the coding standards, but the other bugs about static analysis and unit testing seem to be out of my scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification, errors on the authorize endpoint should be transmitted to the client via a redirect in certain conditions:
https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1
This is not the case currently.
This PR seeks to resolve this case.