Skip to content

The linkedIn response replaced/removed the array key storageSize with displaySize, this change will check for both. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamesNuttall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The linkedIn response replaced/removed the array key storageSize with displaySize, this change will check for both. #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Provider/LinkedInResourceOwner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ private function setSortedProfilePictures()
});
// order images by width, LinkedIn profile pictures are always squares, so that should be good enough
usort($pictures, function ($elementA, $elementB) {
$wA = $elementA['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['storageSize']['width'];
$wB = $elementB['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['storageSize']['width'];
$wA = $elementA['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['storageSize']['width'] ?? $elementA['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['displaySize']['width'];
$wB = $elementB['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['storageSize']['width'] ?? $elementB['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['displaySize']['width'];
return $wA - $wB;
});
$pictures = array_map(function ($element) {
// this is an URL, no idea how many of identifiers there can be, so take the first one.
$url = $element['identifiers'][0]['identifier'];
$type = $element['identifiers'][0]['mediaType'];
$width = $element['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['storageSize']['width'];
$width = $element['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['storageSize']['width'] ?? $element['data']['com.linkedin.digitalmedia.mediaartifact.StillImage']['displaySize']['width'];
return [
'width' => $width,
'url' => $url,
Expand Down