Fix: Make fetching metaData and the download and response functions work with SSE-C in AwsS3V3 #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a to make the metaData, download and response functions work with SSE-C enabled as HeadObject requires the SSE-C headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 Command "HeadObject" that is used to fetch a files MetaData(mimeType, size, ...) does not work right now when SSE-C is used. This is because when SSE-C is enabled "HeadObject" requires the SSEC headers(SSECustomerAlgorithm, SSECustomerKey) to be present. Since fetchFileMedata is also used in the download and response functions, it is not possible right now to download a file when SSE-C is enabled. This pull request fixes this in that it adds the options also to the "HeadObject" command as it is already done in the readObject function (aka "GetObject" command).