Fix buffering issue in nic #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey, thanks for this pr! Out of curiosity, what is your nic use case where you encounter this buffering issue? |
Author
|
I'm running it as a part of a build system workflow from a Python application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Without this fix, prompt printed to
$::savedStdoutis buffered when stdout is a pipe. The subsequent$| = 1clause does not help because it happens only after we print.Does this close any currently open issues?
No.
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Operating System: Linux (NixOS)
Platform: …
Target Platform: …
Toolchain Version: …
SDK Version: …