feat: Add test for solid harmonic moment translation (#159) #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/grid/tests/test_molgrid.py:78
- [nitpick] Consider renaming the variable 'l_check' (used for recalculating 'l' in get_lm_from_horton_index) to a more descriptive name, such as 'corrected_l', to improve code clarity.
l_check = 0
|
Hi! @PaulWAyers @marco-2023 @Ali-Tehrani I’ve addressed the feedback from Copilot AI by renaming l_check to corrected_l for better clarity. The updated code has been pushed, and all tests still pass. Please let me know if there’s anything else to address! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a unit test (
test_multipole_translation) to verify that solid harmonic moments calculated byGrid.momentsbehave correctly under origin translation, as required by issue #159. The test compares numerical results against the analytical formula and passe.