New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Langman subdirectories #72

Open

nicolasbeauvais wants to merge 2 commits into themsaid:master from nicolasbeauvais:langman-subdirectories

nicolasbeauvais commented Oct 9, 2017

Make laravel-langman work with lang files in subdirectories:

lang
  |_ en
      |_something
         |_file.php
  |_ fr
      |_something
         |_file.php

The file parsing (https://github.com/themsaid/laravel-langman/compare/master...nicolasbeauvais:langman-subdirectories?expand=1#diff-e07e4dbec2b7af0db87b7c9a92ddee86R61) could be improved with the new Str::before and Str::after methods but it would require illuminate/support:5.5 so I did it in a less fashionable way.

I renamed the $fileName var to $filePath as it makes more sense now.

I only had to change two lines of code to make it work, you made some very steady code 👍

nicolasbeauvais added 2 commits

October 9, 2017 23:58


          Remove unused use statement

c5c15f6


          Make langman works with subdirectories

c588066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet