-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(remix): added additional notes for using Remix Link API #1280
base: main
Are you sure you want to change the base?
Conversation
if we are using Remix API Layer Link from @remix-run/react, and using it == as={Link} then replace the href with to, and we can use href if we are not using Link on naNavbar.Link & Sidebar.Item
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 99.54% 97.35% -2.20%
==========================================
Files 163 216 +53
Lines 6621 9224 +2603
Branches 401 538 +137
==========================================
+ Hits 6591 8980 +2389
- Misses 30 244 +214 ☔ View full report in Codecov by Sentry. |
Hello @SutuSebastian , Sorry to bother you, but can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we simplify the text a bit? so its more concise and easier to understand
I wrote this explanation with examples for better understanding. but let me try if I can simplify the text. @SutuSebastian |
Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places. Logic behind: register once -> it just works. |
Sounds Great!.. I would be happy to help you & contribute with you more on this. |
can I close this PR? @SutuSebastian |
keep it for a while, so we can close it with reference. |
Needs a sync with |
if we are using Remix API Layer Link from @remix-run/react, and using it ==
as={Link}
then replace the href with to, and we can use href if we are not using Link onNavbar.Link
&Sidebar.Item