Repository navigation
fix(cohort): #20 follow-ups + clear mypy errors - #22
Merged
Merged
Conversation
- `|` / `-` return NotImplemented for non-cohort operands (TypeError, not AttributeError) - slicing/filter/where of a split fold keep `.split_manifest`; a union keeps it only when both sides share the same split - download fallback warning uses stacklevel=3 so it points at the caller - mypy: annotate `_is_null`, narrow `want` in `Catalog.cohort`, type MCP facets dict
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 92.00% 92.05% +0.05%
==========================================
Files 18 18
Lines 1450 1460 +10
==========================================
+ Hits 1334 1344 +10
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups listed as non-blocking in #20, plus the four pre-existing mypy errors.
Cohort
SpatialDataCohort.__or__/__sub__returnNotImplementedfor non-cohort operands →TypeErrorinstead ofAttributeError.filter()andwhere()on a split fold keep.split_manifest(__getitem__now goes through_derive). A union keeps the manifest only when both operands share the same split; otherwise it isNone.stacklevel=3so it points at the user'scohort.download(...)call.Typing:
mypy srcis now clean (_is_nullannotation,Catalog.cohortnarrowing, MCPfacetsdict typeddict[str, Any]).Tests: 289 passed, 4 skipped; new tests cover each fix (all failed before the change).