Repository navigation
A file may lack a rep its streams never select from - #23
Closed
selmanozleyen wants to merge 1 commit into
Closed
selmanozleyen wants to merge 1 commit into
selmanozleyen wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded: scfit already supports this through separate sources (a link stream on its own source_key binds to the primary via match_on). sckitflow will route each file to the target and/or control source by role, so no placeholder is needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dataset split across files can keep each side's rep only where it lives, e.g.
obsm/X_srconly in the controls' file andobsm/X_tgtonly in the perturbed one (a quadratic coupling). Before, every file had to carry every rep a stream asks for, even files the stream never selects rows from.Source.rep(loc, needed)gives a file that lacks the rep and has no selected rows a never-read placeholder (an unwritten in-memory zarr array or empty CSR group when backed, a broadcast zero view or empty CSR matrix in memory), so annbatch still gets one backing per file. A missing rep in a selected file raises._read_rowsreads the rep only from files that hold selected rows.load_backed_adata/open_sourceskip a key a file does not have, leaving the decision toSource.rep.