Repository navigation
annbatch 0.3 samplers, no shim - #19
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the annbatch shim (vendored fork samplers plus a monkeypatched
Loader.__iter__) and theannbatch==0.2.1pin.annbatch>=0.3.1: it ships the #256 multi-dataset fix and a reworkedClassSampler(withRLEManager).ClassSampler.BoundClassSampler(scfit/data/_bound_sampler.py), aClassSamplersubclass. For each batch of the primary's schedule it draws one of its own classes matching onmatch_on, ∝ its weights within that context, and reads whole chunks of it through annbatch'sRLEManager. An inner class with no positive-weight match is refused at construction.batch["label"]: each per-rep loader carries every row's leaf as an obs column, and a batch's leaf is its first row's. A link now reports its own leaf directly (it no longer carries thematch_onprefix).All existing data tests pass unchanged against annbatch 0.3.1, plus two for
BoundClassSampler.