Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neural Updates: Move GENOTLinProblem, Update SolverOutput Class Hierarchy #778

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

selmanozleyen
Copy link
Collaborator

@selmanozleyen selmanozleyen commented Jan 7, 2025

Important things to note:

  • removed this class from the user.rst file because I think it should be tested more to be exposed in the docs
  • In project_to_transport_matrix I removed the forward argument since for that class forward is always true.
  • In general I added a method _apply_forward to the base output class so it includes both the neural and non-neural case. This might seem like more code but checking every time for forward=False and throwing an error is probably more problematic and has more code. For the old moscot classes nothing changes. _apply_forward is also simply supported with def _apply_forward(x): return apply(x, forward=True)

@selmanozleyen selmanozleyen changed the title Neural Updates: Move GENOTLinProblem to neural module Neural Updates: Move GENOTLinProblem, Update SolverOutput Class Hierarchy Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 77.61194% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (8c31536) to head (b55a0e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/moscot/backends/ott/output.py 31.25% 10 Missing and 1 partial ⚠️
src/moscot/neural/problems/generic/_generic.py 91.30% 2 Missing ⚠️
src/moscot/base/cost.py 0.00% 1 Missing ⚠️
src/moscot/base/output.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   77.37%   77.46%   +0.09%     
==========================================
  Files          36       37       +1     
  Lines        4363     4363              
  Branches      678      677       -1     
==========================================
+ Hits         3376     3380       +4     
+ Misses        662      657       -5     
- Partials      325      326       +1     
Files with missing lines Coverage Δ
src/moscot/_types.py 100.00% <100.00%> (+9.09%) ⬆️
src/moscot/backends/ott/_utils.py 69.71% <100.00%> (+0.21%) ⬆️
src/moscot/backends/ott/solver.py 91.69% <100.00%> (ø)
src/moscot/backends/utils.py 77.77% <100.00%> (ø)
src/moscot/base/problems/_utils.py 64.03% <100.00%> (ø)
src/moscot/problems/generic/_generic.py 94.02% <100.00%> (+1.25%) ⬆️
src/moscot/problems/space/_mapping.py 96.05% <ø> (ø)
src/moscot/problems/space/_mixins.py 82.73% <100.00%> (+0.06%) ⬆️
src/moscot/problems/time/_lineage.py 96.29% <100.00%> (ø)
src/moscot/problems/time/_mixins.py 63.84% <ø> (ø)
... and 4 more

selmanozleyen and others added 2 commits January 8, 2025 00:11
…ss always have it. as a solution in the future we can check the convergence of minibatch solve results...Then move NeuralOTProblem to its module
Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@selmanozleyen selmanozleyen merged commit 41c57a1 into main Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants