-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neural Updates: Move GENOTLinProblem, Update SolverOutput Class Hierarchy #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
8 tasks
selmanozleyen
changed the title
Neural Updates: Move GENOTLinProblem to neural module
Neural Updates: Move GENOTLinProblem, Update SolverOutput Class Hierarchy
Jan 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 77.37% 77.46% +0.09%
==========================================
Files 36 37 +1
Lines 4363 4363
Branches 678 677 -1
==========================================
+ Hits 3376 3380 +4
+ Misses 662 657 -5
- Partials 325 326 +1
|
…ss always have it. as a solution in the future we can check the convergence of minibatch solve results...Then move NeuralOTProblem to its module
for more information, see https://pre-commit.ci
MUCDK
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important things to note:
project_to_transport_matrix
I removed theforward
argument since for that class forward is always true._apply_forward
to the base output class so it includes both the neural and non-neural case. This might seem like more code but checking every time for forward=False and throwing an error is probably more problematic and has more code. For the old moscot classes nothing changes._apply_forward
is also simply supported withdef _apply_forward(x): return apply(x, forward=True)