Have Appveyor run nanomsg_sys tests; Fix nanomsg_sys tests on Windows. #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #132 and #133.
I realized that Appveyor was not running tests for nanomsg_sys so I have fixed that. The results from that commit can be seen here. You can see that
tests::constants_should_match_return_of_symbol_func()
failed andtests::should_create_a_pubsub()
ended up blocking.I fixed
tests::should_create_a_pubsub()
by increasing the sleep time and fixedtests::constants_should_match_return_of_symbol_func()
by changing more Windows specific constants. The passing build can be found here.@blabaere In regards to the comment left on my previous commit, my intuition when it comes to the differences between C runtimes is lacking. If I understand correctly, the constants can vary between operating systems and compilers? I know that in the two main compilers for Windows (gcc via mingw and msvc) both of the
errno.h
constants were identical. I can't speak for how they might vary in other circumstances.