plugin/discovery: use refreshonly on the untar exec#822
Open
kenyon wants to merge 1 commit intotheforeman:masterfrom
Open
plugin/discovery: use refreshonly on the untar exec#822kenyon wants to merge 1 commit intotheforeman:masterfrom
refreshonly on the untar exec#822kenyon wants to merge 1 commit intotheforeman:masterfrom
Conversation
kenyon
force-pushed
the
discovery-untar
branch
from
6202c31 to
b4e4d7e
Compare
kenyon
force-pushed
the
discovery-untar
branch
from
ee88266 to
14784e7
Compare
kenyon
force-pushed
the
discovery-untar
branch
from
14784e7 to
4088434
Compare
kenyon
force-pushed
the
discovery-untar
branch
from
4088434 to
94d8451
Compare
Previously, if you change the image_name (such as for updating the Foreman Discovery Image version), the new tar file would be downloaded but not untarred because the content of the previous tar file would be there and pass the `creates` check. If we use `refreshonly` instead of `creates`, the untar exec will be executed when the tar file is updated, as expected. See also: theforeman#774 (comment)
kenyon
force-pushed
the
discovery-untar
branch
from
3155edc to
d1cac68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if you change the
image_name(such as for updating the Foreman Discovery Image version), the new tar file would be downloaded but not untarred because the content of the previous tar file would be there and pass thecreatescheck.If we use
refreshonlyinstead ofcreates, the untar exec will be executed when the tar file is updated, as expected.See also: #774 (comment)