Fixes #35851 - Add parameter tftp system_image_root

[bastian-src]

Refer to Smart Proxy PR for more information.

Add configurable parameter system_image_root.

[bastian-src]

Need some help to resolve build issue

foreman_proxy::plugin::acd
  on debian-11-x86_64
    with default settings
      is expected to contain Class[foreman_proxy::plugin::remote_execution::script] (FAILED - 2)
      is expected to contain Foreman_proxy::Plugin::Module[acd] (FAILED - 1)
      is expected to contain Foreman_proxy::Plugin::Module[ansible] (FAILED - 3)
      is expected to contain Package[python3-ansible-runner] with ensure => "installed" (FAILED - 4)
      acd.yml should contain the correct configuration (FAILED - 2)

[bastian-src]

@ekohl do you maybe have an idea why these build errors occur?

[ekohl]

It fails because you enforce that the value is NotUndef when tftp is enabled, but you never provide a value for it. So it fails to compile.

I want to get back to your PR series, but I probably won't have time this week and then my first working day is in the new year.

[bastian-src]

Thanks a lot for your review! It helps a lot.

And thanks also for letting me know the time-frame for my other PRs!

[bastian-src]

Hey @ekohl! Hope u had a good time and nice holidays. Let me know if you get back to this topic, I'll be happy to help getting the Autoinstall automation feature merged 👍

The main PRs, besides this one, are the following:

• foreman
• smart-proxy
• foreman-packaging deb and rpm

[ekohl]

@bastian-src sorry, right now I'm swamped with preparing for the Belgian conferences and after that with Foreman 3.6 branching. I wouldn't mind if someone else takes care of reviews but I can't promise anything about myself right now.

[bastian-src]

@ekohl Thanks for your response! I guess more developers might be busy until then. Shall I just ping you in 3-5 weeks again?

[bastian-src]

@ekohl hey! I've rebased the branches mentioned before and tests are green.
The errors here seem unrelated - I guess we can just re-trigger tests.

Do you have some time for the PRs in the next couple of days or shall we re-schedule?

[bastian-src]

@ekohl rebased to latest master :)

Hope you find some time soon 🤞