Fixes #33590 - Support multiple DNS domains#705
Draft
ekohl wants to merge 1 commit intotheforeman:masterfrom
Draft
Fixes #33590 - Support multiple DNS domains#705ekohl wants to merge 1 commit intotheforeman:masterfrom
ekohl wants to merge 1 commit intotheforeman:masterfrom
Conversation
This changes the dns_zone option from an optional string to an array which allows creating multiple zones. For compatibility it still supports the single string and undef options. In a major release this should be changed to only accept an array.
Member
seems some tests still need adjustment, but overall 👍 |
Member
Author
|
One thing I just realized is that this will also create entries for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the dns_zone option from an optional string to an array which allows creating multiple zones. For compatibility it still supports the single string and undef options. In a major release this should be changed to only accept an array.