move seed username/password to secrets #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Lint fix in #274 |
ehelms
approved these changes
Oct 30, 2025
Member
ehelms
left a comment
ehelms
left a comment
There was a problem hiding this comment.
I like the alignment to secrets for consistency. These seeds are kinda goofy since after the first run they are effectively useless and pointless to keep around. I guess put this on the pile of things to make better, this is good enough for now.
arvind4501
approved these changes
Nov 4, 2025
Contributor
arvind4501
left a comment
arvind4501
left a comment
There was a problem hiding this comment.
Before:- foremanctl deploy --foreman-initial-admin-password=changeme
podman exec foreman env | grep SEED_*
SEED_ADMIN_PASSWORD=changeme
SEED_ADMIN_USER=admin
After applying packit and redeploying
podman secret ls | grep foreman-seed
d3e7bc24c17b2876e76beb348 foreman-seed-admin-password file 5 minutes ago 5 minutes ago
2e59a9e7bebf10f32bc49f982 foreman-seed-admin-user file 5 minutes ago 5 minutes ago
Seems to work as expected, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.