Conversation
29 tasks
ofedoren
reviewed
Jan 12, 2024
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
What should we do about https://github.com/theforeman/foreman_discovery/pull/612/files#diff-5bf32edc05219804403641dadf678cb09f975f656b06b6a199c1c737ebaf34ebR11 ? Mention it explicitly or wait for theforeman/actions#16?
Otherwise LGTM and looks like this is the way now/near future.
ekohl
approved these changes
Jan 12, 2024
| - name: Run plugin tests | ||
| run: | | ||
| bundle exec rake test:foreman_webhooks | ||
| bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb" |
ekohl
reviewed
Jan 12, 2024
ekohl
reviewed
Jan 23, 2024
ofedoren
approved these changes
Jan 25, 2024
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Thanks, @adamruzicka and @ekohl !
ofedoren
pushed a commit
to ofedoren/foreman_webhooks
that referenced
this pull request
Aug 7, 2025
* Rewrite to a shared GitHub Actions workflow * Also trigger CI on push to master (cherry picked from commit e62c40d)
ofedoren
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Rewrite to a shared GitHub Actions workflow * Also trigger CI on push to master (cherry picked from commit e62c40d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.