Recreate webhooks integration test from robottelo#94
Recreate webhooks integration test from robottelo#94adamruzicka merged 1 commit intotheforeman:masterfrom
Conversation
adamlazik1
force-pushed
the
integration_test
branch
from
024713f to
366c5bf
Compare
I have observed that the webhooks UI test can take up to 10 minutes to execute on local robottelo instance and up to 20+ minutes on PRT testing. This is with applied changes from SatelliteQE/airgun#2256 which update the test to pass after the webhook PF5 update. Without these changes, the test takes even longer. I do not think that this is a reasonable time for what the test does. I have recreated this test in foreman_webhooks: theforeman/foreman_webhooks#94 This test copies the functionality 1:1 and also tests on a live server using the Capybara framework. It takes on average 90 seconds to complete. Due to a sizable difference in a time needed for completion, I propose to replace test_webhook.py with the test in foreman_webhooks and to rely on testing in the foreman_webhooks repository when it comes to UI. This will contribute a tiny bit to reducing strain on our testing infrastructure.
|
#89 was merged; I would appreciate a review on this. I would like this test to replace in webhooks UI test in robottelo. For more information see SatelliteQE/airgun#2256 |
adamlazik1
force-pushed
the
integration_test
branch
from
366c5bf to
c8a189c
Compare
adamlazik1
changed the title
pnovotny
left a comment
pnovotny
left a comment
There was a problem hiding this comment.
Although I am not an expert on UI testing in Ruby or capybara, the test looks good to me.
One side note: if you decide in the future to extend the UI test here in foreman repo, you would most probably need to refactor the helper methods into more reusable format.
This could lead to that you'll end up with you own implementation of robottelo's airgun & Widgetastic & similar libraries that you'll need to maintain on your own(-ish).
Just a thought to be aware of.
adamlazik1
force-pushed
the
integration_test
branch
from
c8a189c to
a3cc611
Compare
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
Could the test be broken up somehow? Currently it is a single test that covers like 95% of the plugin's ui making the test results very much all or nothing
adamlazik1
force-pushed
the
integration_test
branch
from
a3cc611 to
cb40f71
Compare
Updated. |
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
One last nitpick, otherwise lgtm
adamlazik1
force-pushed
the
integration_test
branch
from
cb40f71 to
d666312
Compare
|
Thank you @adamlazik1 ! |
I have observed that the webhooks UI test can take up to 10 minutes to execute on local robottelo instance and up to 20+ minutes on PRT testing. This is with applied changes from SatelliteQE/airgun#2256 which update the test to pass after the webhook PF5 update. Without these changes, the test takes even longer. I do not think that this is a reasonable time for what the test does. I have recreated this test in foreman_webhooks: theforeman/foreman_webhooks#94 This test copies the functionality 1:1 and also tests on a live server using the Capybara framework. It takes on average 90 seconds to complete. Due to a sizable difference in a time needed for completion, I propose to replace test_webhook.py with the test in foreman_webhooks and to rely on testing in the foreman_webhooks repository when it comes to UI. This will contribute a tiny bit to reducing strain on our testing infrastructure.
3 participants
Depends on #89