Remove the webhooks UI test in favor of upstream testing

[adamlazik1]

Problem Statement

I have observed that the webhooks UI test can take up to 10 minutes to execute on local robottelo instance and up to 20+ minutes on PRT testing. This is with applied changes from the airgun PR which update the test to pass after the webhook PF5 update. Without these changes, the test takes even longer. I do not think that this is a reasonable time for what the test does.

Solution

I have recreated this test in foreman_webhooks. This test copies the functionality 1:1 and also tests on a live server using the Capybara framework. It takes on average 90 seconds to complete. Due to a sizable difference in a time needed for completion, I propose to replace test_webhook.py with the test in foreman_webhooks and to rely on testing in the foreman_webhooks repository when it comes to UI. This will contribute a tiny bit to reducing strain on our testing infrastructure.

Related Issues

PF 5 webhooks update: (foreman_webhooks): theforeman/foreman_webhooks#89
PF 5 webhooks update: (airgun): SatelliteQE/airgun#2256
Recreation of the test in foreman_webhooks: theforeman/foreman_webhooks#94

Summary by Sourcery

Remove the webhooks UI test and its associated ownership metadata in favor of relying on upstream UI testing in the foreman_webhooks project.

CI:

• Update CODEOWNERS to remove entries related to the deleted webhooks UI test.

Tests:

• Delete the slow webhooks UI test suite to rely on upstream webhooks UI coverage.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the slow webhooks UI integration test from this repository in favor of running an equivalent UI test upstream in the foreman_webhooks project, and adjusts CODEOWNERS accordingly.

File-Level Changes

Change	Details	Files
Remove the long-running webhooks UI test to rely on upstream foreman_webhooks UI coverage instead.	Delete the webhooks UI Robot/airgun-based test module that exercised webhook creation/validation via the UI. Eliminate any local test runtime and maintenance burden associated with the old webhooks UI scenario.	tests/foreman/ui/test_webhook.py
Align CODEOWNERS with the removal of the webhooks UI test file.	Update CODEOWNERS entries so they no longer reference the deleted webhooks UI test file or its previous ownership. Ensure remaining CODEOWNERS patterns still accurately reflect current test file ownership.	.github/CODEOWNERS

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[adamruzicka]

In the meantime, we merged theforeman/foreman_webhooks#94 making the original test here an unnecessary duplicate. With that being said, let's drop it from here