Skip to content

Fixes #39018 - Fix infinite loop on job invocations page #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariaAga merged 1 commit into from
Jan 30, 2026
Merged

Fixes #39018 - Fix infinite loop on job invocations page #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions webpack/react_app/components/TargetingHosts/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ const WrappedTargetingHosts = () => {
}
}, [dispatch, intervalExists]);

// Use ref to avoid infinite loop from handleSearch depending on pagination.per_page
// Use refs to avoid infinite loop from handleSearch depending on pagination.per_page and searchQuery
const perPageRef = useRef(pagination.per_page);
const searchQueryRef = useRef(searchQuery);

const handleSearch = useCallback(
(query, status) => {
Expand All @@ -71,11 +72,15 @@ const WrappedTargetingHosts = () => {
[stopApiInterval]
);

// Keep ref in sync with pagination
// Keep refs in sync with state
useEffect(() => {
perPageRef.current = pagination.per_page;
}, [pagination.per_page]);

useEffect(() => {
searchQueryRef.current = searchQuery;
}, [searchQuery]);

const handlePagination = useCallback(
args => {
stopApiInterval();
Expand Down Expand Up @@ -112,9 +117,19 @@ const WrappedTargetingHosts = () => {
};
}, [dispatch, apiUrl, autoRefresh, getData]);

// Only respond to external statusFilter changes (from chart clicks)
// searchQuery changes are handled directly by handleSearch calls from the UI
useEffect(() => {
handleSearch(searchQuery, statusFilter);
}, [statusFilter, searchQuery, handleSearch]);
dispatch(stopInterval(TARGETING_HOSTS));
const defaultPagination = { page: 1, per_page: perPageRef.current };
setApiUrl(
getApiUrl(
buildSearchQuery(searchQueryRef.current, statusFilter),
defaultPagination
)
);
setPagination(defaultPagination);
}, [statusFilter, dispatch]);

return (
<TargetingHostsPage
Expand Down