Fixes #39210 - Fix the tests#441
Conversation
| result += untaxed_environments | ||
| end | ||
| result | ||
| ForemanPuppet::Environment.authorized(:view_environments).pluck(:name) |
There was a problem hiding this comment.
This currently requires theforeman/foreman#10898 . An alternative would be this suggestion
| ForemanPuppet::Environment.authorized(:view_environments).pluck(:name) | |
| ForemanPuppet::Environment.authorized(:view_environments).distinct.pluck(:name) |
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
This should also bump required foreman version if we merge the change in core :/
|
And maybe it's worth to create a RM issue to link to the core's one? And if the tests fail, I guess it won't hurt to add a commit to run this CI with theforeman/foreman#10898 to ensure the tests pass with that change. Although this is pretty straightforward issue/change (thus not required), I'd like to make a pattern from testing with the dependency. |
Yeah, I have it ready, I was just waiting for the tests to fail. |
| @@ -1,5 +1,5 @@ | |||
| Foreman::Plugin.register :foreman_puppet do | |||
| requires_foreman '>= 3.13' | |||
| requires_foreman '>= 3.19' | |||
There was a problem hiding this comment.
Thanks for fixing! Let's keep in mind to do a major version bump during the next release.
3 participants
This most likely broke when theforeman/foreman#10701 went in.