Skip to content

Fix js lints #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamruzicka merged 1 commit into from
Jul 8, 2025
+3 −3
Merged

Fix js lints #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@
key="foreman-puppet-metrics-table"
>
<Tbody>
<Tr>
<Tr ouiaId="foreman-puppet-metrics-row-1">
{createPuppetMetricsTableElement(__('Failed'), metrics.failed)}
{createPuppetMetricsTableElement(__('Changed'), metrics.changed)}
{createPuppetMetricsTableElement(__('Scheduled'), metrics.scheduled)}
</Tr>
<Tr>
<Tr ouiaId="foreman-puppet-metrics-row-2">
{createPuppetMetricsTableElement(
__('Failed to start'),
metrics.failed_to_start
Expand All @@ -120,7 +120,7 @@
metrics.corrective_change
)}
</Tr>
<Tr>
<Tr ouiaId="foreman-puppet-metrics-row-3">
{createPuppetMetricsTableElement(__('Skipped'), metrics.skipped)}
{createPuppetMetricsTableElement(
__('Out of sync'),
Expand Down Expand Up @@ -148,7 +148,7 @@

useEffect(() => {
getLastReport();
}, [hostName, reports]);

Check warning on line 151 in webpack/src/Extends/Host/PuppetTab/SubTabs/Reports/components/ConfigStatusCard/index.js

View workflow job for this annotation

GitHub Actions / JavaScript / Foreman develop Ruby 2.7 and Node 18 

React Hook useEffect has a missing dependency: 'getLastReport'. Either include it or remove the dependency array

const { metrics } = useSelector(state =>
selectAPIResponse(state, FOREMAN_PUPPET_LAST_REPORT_KEY)
Expand Down