Rewrite GHA workflow using reusable actions#381
Merged
ekohl merged 2 commits intotheforeman:masterfrom Feb 1, 2024
Merged
Conversation
archanaserver
commented
Jan 11, 2024
Comment on lines
-84
to
-91
| - name: Run plugin tests | ||
| if: github.event_name != 'push' | ||
| run: | | ||
| bundle exec rake test:foreman_puppet | ||
| - name: Run access permission test | ||
| if: ${{ github.event_name != 'push' }} | ||
| run: | | ||
| bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb" |
Contributor
Author
There was a problem hiding this comment.
This steps has not yet executed in the reusable action.
archanaserver
commented
Jan 11, 2024
Comment on lines
-47
to
-48
| - name: Install chromedriver | ||
| uses: nanasess/setup-chromedriver@master |
Contributor
Author
There was a problem hiding this comment.
@ekohl i can't see this step execution in the reusable action, do we want to execute this one? i'm not aware of this one.
Member
There was a problem hiding this comment.
We need a browser for the acceptance tests. I think a separate container that runs selenium together with theforeman/foreman#9952 could be an alternative. It would be best to track this by opening an issue on https://github.com/theforeman/actions or at least mention it in theforeman/actions#1
Contributor
Author
There was a problem hiding this comment.
29 tasks
ekohl
reviewed
Jan 11, 2024
archanaserver
commented
Jan 26, 2024
Merged
Contributor
Author
|
@ekohl how the workflow is not getting triggered? i wonder if any checks i'm missing here :/ |
ekohl
requested changes
Jan 31, 2024
ekohl
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated GitHub Action workflow using shared Rubocop and Foreman plugin test actions.
https://github.com/theforeman/actions#rubocop
https://github.com/theforeman/actions#foreman-plugin-tests