Use documentation URL helper from core#578
Merged
ofedoren merged 1 commit intotheforeman:masterfrom Aug 1, 2024
Merged
Conversation
Foreman 3.9.1+ has built in support to link to docs. This simplifies the code in this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foreman 3.9.1+ has built in support to link to docs. This simplifies the code in this module.
There is some downstream branding consideration. Either https://github.com/RedHatSatellite/foreman_theme_satellite/blob/bf42fb119af723df5080e9b5d0f73fd8c483e017/lib/foreman_theme_satellite/documentation.rb#L67-L72 needs to be updated or RedHatSatellite/foreman_theme_satellite#58 needs to be merged.