Clean up load_configuration methods in *_database#946
Draft
ekohl wants to merge 3 commits intotheforeman:masterfrom
Draft
Clean up load_configuration methods in *_database#946ekohl wants to merge 3 commits intotheforeman:masterfrom
ekohl wants to merge 3 commits intotheforeman:masterfrom
Conversation
This refactors load_configuration to return a simple hash and do the caching in the method configuration.
ekohl
force-pushed
the
clean-db-load-config
branch
from
f94f236 to
2b6a059
Compare
ekohl
commented
Oct 18, 2024
| @configuration['password'] = db_config['PASSWORD'] | ||
| @configuration | ||
| { | ||
| 'adapter' => 'postgresql', |
Member
Author
There was a problem hiding this comment.
We never use this, so why do we need this?
Comment on lines
+48
to
53
| 'ssl' => query['ssl']&.first == 'true', | ||
| 'sslfactory' => query['sslfactory']&.first, | ||
| 'driver_class' => full_config['jpa.config.hibernate.connection.driver_class'], |
Member
Author
There was a problem hiding this comment.
We never use these, so why do we have these?
Member
There was a problem hiding this comment.
pretty sure we don't need them and can drop 'em
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors
load_configurationto return a simple hash and do the caching in the methodconfiguration. It then also usesURIandCGIto parse the Candlepin DB URL instead of using regular expressions.