Draft
Conversation
ekohl
reviewed
May 8, 2023
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
👍 for renaming because it really is a blacklist, rather than a whitelist. Still, skip is an even better description.
| @upgrade_runner = ForemanMaintain::UpgradeRunner.new(target_version, reporter, | ||
| :assumeyes => assumeyes?, | ||
| :whitelist => whitelist || [], | ||
| :whitelist => skip || [], |
Member
There was a problem hiding this comment.
Should it also internally refactor?
8 tasks
The whitelist option doesn't accurately capture what will happen when steps are supplied to the option. The change to --skip can help to better understand that steps included with it will be skipped.
ehelms
force-pushed
the
introduce-skip
branch
from
d751d89 to
1fbaad5
Compare
ekohl
reviewed
Sep 21, 2023
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Would it make sense to keep --whitelist but issue a deprecation warning?
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whitelist option doesn't accurately capture what will happen when steps are supplied to the option. The change to --skip can help to better understand that steps included with it will be skipped.