Require steps to be explicitly marked as skippable for whitelisting#714
Draft
ehelms wants to merge 1 commit intotheforeman:masterfrom
Draft
Require steps to be explicitly marked as skippable for whitelisting#714ehelms wants to merge 1 commit intotheforeman:masterfrom
ehelms wants to merge 1 commit intotheforeman:masterfrom
Conversation
This makes a change to whitelist logic to require steps to be explicitly marked as 'skippable' in the code to be whitelistable by users. Previously, everything was assumed to be skippable and steps had to be marked that they could not be whitelisted. This can lead to steps in processes like upgrades being skipped by users when they should not be causing more problems. This may have an impact on users used to skipping certain steps, but will enforce more forethought on what a user should be able to skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a change to whitelist logic to require steps to be explicitly marked as 'skippable' in the code to be whitelistable by users. Previously, everything was assumed to be skippable and steps had to be marked that they could not be whitelisted. This can lead to steps in processes like upgrades being skipped by users when they should not be causing more problems.
This may have an impact on users used to skipping certain steps, but will enforce more forethought on what a user should be able to skip.
I am starting this as a draft, as it's a reversal of logic, and should include a review of all possible steps that we may deem skippable at the outset. This is also a bit tricky because there may be cases where the step and the context have to be taken into consideration -- which this solution does not provide an answer for at present.
Steps that have currently been marked skippable were pulled from our documentation.