execute amcheck before doing backups

[evgeni]

this ensures that the database is restorable or if it isn't (when there are index issues) the user knows at the time of the backup

[evgeni]

# foreman-maintain health check --tags db-index
Running ForemanMaintain::Scenario::FilteredScenario
================================================================================
Make sure Candlepin DB indexes are OK:                                [OK]
--------------------------------------------------------------------------------
Make sure Foreman DB indexes are OK:                                  [FAIL]
Foreman DB indexes have issues:
ERROR:  item order invariant violated for index "index_fact_names_on_name_and_type"
DETAIL:  Lower index tid=(1,7) (points to heap tid=(0,5)) higher index tid=(1,8) (points to heap tid=(0,4)) page lsn=0/2ED6F40.
--------------------------------------------------------------------------------
Make sure Pulpcore DB indexes are OK:                                 [OK]
--------------------------------------------------------------------------------
Scenario [ForemanMaintain::Scenario::FilteredScenario] failed.

The following steps ended up in failing state:

  [foreman-db-index]

Resolve the failed steps and rerun the command.

If the situation persists and, you are unclear what to do next,
contact Red Hat Technical Support.

In case the failures are false positives, use
--whitelist="foreman-db-index"

[ehelms]

Should we just create/enable amcheck as a default extension in our installations?

[evgeni]

Should we just create/enable amcheck as a default extension in our installations?

We can do that, sure.

Having it here made it easier to test the whole thing on an existing (old) box.

[evgeni]

• install amcheck extension for PostgreSQL puppet-pulpcore#387
• install amcheck extension for PostgreSQL puppet-foreman#1232
• install amcheck extension for PostgreSQL puppet-candlepin#271

[ekohl]

Just noting for myself: we don't need to install postgresql-contrib on external DBS because this check is only executed locally.

[ekohl]

Should it check for the column we want to be present instead of just non-empty?

Suggested change

	!result.nil? && !result.empty?
	!result.nil? && result.include?('amcheck_installed')

[evgeni]

Right now result is something like [{"?column?"=>"amcheck_installed"}], so the include? would need to be a tad more smart, but it's really not necessary, as the result will be empty if the extensions is not there.