Skip to content

Fixes #39051 - Add expandable info to leapp reports#166

Open
kmalyjur wants to merge 1 commit intotheforeman:masterfrom
kmalyjur:job-inv-leapp-info
Open

Fixes #39051 - Add expandable info to leapp reports#166
kmalyjur wants to merge 1 commit intotheforeman:masterfrom
kmalyjur:job-inv-leapp-info

Conversation

@kmalyjur
Copy link
Contributor

@kmalyjur kmalyjur commented Feb 2, 2026

Adds expanding functionality and expandable information to the new Leapp preupgrade report table on the job invocation detail page.

Before:
image

After:
image

The test was created with the help of AI.

@Lukshio Lukshio self-assigned this Feb 3, 2026
@Lukshio Lukshio removed their assignment Feb 3, 2026
@MariaAga MariaAga self-assigned this Feb 3, 2026
@MariaAga MariaAga requested a review from Copilot February 3, 2026 14:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds row-level expansion (and an expand-all control) to the Leapp preupgrade report table shown on the job invocation detail page, rendering additional per-entry details when expanded.

Changes:

  • Add expandable row rendering for Leapp report entries and manage expanded-row state.
  • Introduce a ReportDetails component to display expanded per-entry metadata (summary/tags/links/remediations).
  • Add/extend RTL tests to cover section expansion, row expansion, expand-all, pagination, and non-Leapp jobs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
webpack/components/PreupgradeReportsTable/index.js Implements outer section expansion + inner expandable table rows (including expand-all wiring).
webpack/components/PreupgradeReportsTable/tests/PreupgradeReportsTable.test.js Adds tests for expanded content, expand-all, pagination, and rendering conditions.
webpack/components/PreupgradeReportsTable/ReportDetails.js New expanded-row details renderer (description list with labels/links/remediations).
webpack/components/PreupgradeReportsTable/PreupgradeReportsTable.scss Styles to preserve whitespace in expanded detail descriptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

/>
childrenOutsideTbody
onExpandAll={onExpandAll}
areAllRowsExpanded={!areAllRowsExpanded}
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

areAllRowsExpanded is computed as “all visible rows are expanded”, but the value passed into <Table areAllRowsExpanded={...}> is negated (!areAllRowsExpanded). This makes the prop semantics inconsistent and can cause the expand-all toggle UI (label/aria state) to be out of sync with the actual row expansion state. Pass the non-negated value, or (if the Table prop expects the inverse) rename either the prop or the local variable to match the meaning to avoid incorrect behavior.

Suggested change
areAllRowsExpanded={!areAllRowsExpanded}
areAllRowsExpanded={areAllRowsExpanded}

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arrow would be in the opposite direction without the "!". I'm adding a comment.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the comment state that this is per PF instructions? when I saw it I thought we had a bug in out table handling

@kmalyjur kmalyjur requested review from MariaAga February 5, 2026 12:05
@kmalyjur kmalyjur force-pushed the job-inv-leapp-info branch 2 times, most recently from f0beee4 to 318fa5a Compare February 5, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants