Conversation
This was not copied over in the original "move GCE support out of core",
but was recently removed from core [1], resulting in errors like
Cannot find rabl template 'api/v2/compute_resources/gce.json' within registered …
[1] theforeman/foreman@b1f397d
stejskalleos
approved these changes
Feb 5, 2026
Collaborator
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
I checked the other removed files:
- app/views/compute_resources_vms/form/gce/_base.html.erb
- app/views/compute_resources_vms/form/gce/_volume.html.erb
- app/views/compute_resources_vms/index/_gce.html.erb
- app/views/compute_resources_vms/show/_gce.html.erb
All of them are present in foreman_google, so once the CI is green, let's get this in.
Member
Author
|
I am running a robotello test, which was failing with this file missing - will report once it's finished. |
Member
Author
|
It passed, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not copied over in the original "move GCE support out of core", but was recently removed from core [1], resulting in errors like
[1] theforeman/foreman@b1f397d