Skip to content

Use theforeman/actions for GitHub Actions configuration#75

Merged
ekohl merged 2 commits intotheforeman:masterfrom
ekohl:reusable-actions
Jan 19, 2024
Merged

Use theforeman/actions for GitHub Actions configuration#75
ekohl merged 2 commits intotheforeman:masterfrom
ekohl:reusable-actions

Conversation

@ekohl
Copy link
Member

@ekohl ekohl commented Oct 31, 2023

No description provided.

@ekohl ekohl marked this pull request as ready for review January 18, 2024 13:16
@ekohl
Copy link
Member Author

ekohl commented Jan 18, 2024

@evgeni this is the only repo where I tried to also test with Foreman versions and archiving the lock files fails. I suppose the cache key isn't long enough and needs more :(

@ekohl ekohl force-pushed the reusable-actions branch 2 times, most recently from 499a71d to 7c32178 Compare January 18, 2024 16:37
@ekohl ekohl mentioned this pull request Jan 18, 2024
@evgeni
Copy link
Member

evgeni commented Jan 18, 2024

3.8 is failing, which I think is a test setup issue, not a code issue. should we just drop it from the matrix?

Edit: or pick theforeman/foreman#9932 into 3.8?

@ekohl
Copy link
Member Author

ekohl commented Jan 18, 2024

Edit: or pick theforeman/foreman#9932 into 3.8?

I wonder why it even needs PuppetRelatedHelper in the tests. Perhaps we can just drop that.

@evgeni
Copy link
Member

evgeni commented Jan 18, 2024

Edit: or pick theforeman/foreman#9932 into 3.8?

I wonder why it even needs PuppetRelatedHelper in the tests. Perhaps we can just drop that.

WFM

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK once this is green by either

  • dropping 3.8 from the matrix
  • picking that puppet change into 3.8
  • dropping the puppethelper from the tests

:)

@evgeni
Copy link
Member

evgeni commented Jan 19, 2024

now it fails on the branches that do have the helper 🙈

@ekohl
Copy link
Member Author

ekohl commented Jan 19, 2024

How about conditionally including the helper? Let's see what CI says.

@ekohl
Copy link
Member Author

ekohl commented Jan 19, 2024

That's now green.

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever works

@ekohl ekohl merged commit 1df3c35 into theforeman:master Jan 19, 2024
@ekohl ekohl deleted the reusable-actions branch January 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants