Fixes #38031 - Use the same routes constraints as Foreman#743
Merged
nofaralfasi merged 1 commit intotheforeman:masterfrom Nov 27, 2024
Merged
Conversation
498649e to
b05fa02
Compare
ekohl
reviewed
Nov 26, 2024
| :defaults => { apiv: 'v2' }, | ||
| :apiv => /v2/, | ||
| :constraints => ApiConstraints.new(version: 2, default: true) do | ||
| constraints(:id => %r{[^\/]+}) do |
Member
There was a problem hiding this comment.
I'm fine merging this because it exactly matches what's in Foreman, but I wonder if %r{[^/]+} would also work?
Member
Author
There was a problem hiding this comment.
It should, since it's still accurate than the previous one, but I'd rather sync between core and plugins.
ekohl
approved these changes
Nov 26, 2024
Contributor
|
Thanks @ofedoren! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
Implementation Considerations
GET /api/v2/hosts/<fqdn_or_id>/poweris not recognized in API calls, even though it's listed internally (e.g. rails routes command) on Rails 7.0.Testing Steps
Checklists
Additional Notes