Use reusable GitHub Actions for testing#519
Merged
nofaralfasi merged 2 commits intotheforeman:masterfrom Jan 28, 2024
Merged
Conversation
ekohl
force-pushed
the
reusable-workflows
branch
from
b0adeaf to
41afbf4
Compare
29 tasks
Contributor
|
Upon reviewing the PR, it seems that it has been open for quite some time without recent activity. In order to keep our repository organized and up-to-date, we've decided to close this draft PR for now. |
ekohl
force-pushed
the
reusable-workflows
branch
from
41afbf4 to
f4be66a
Compare
ekohl
commented
Oct 31, 2023
Member
Author
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Still a TODO, but this needs to happen. The current action is using wrong versions for NodeJS today. It will get worse once we add Ruby 3 to the test matrix.
ekohl
force-pushed
the
reusable-workflows
branch
from
f4be66a to
61bb4c6
Compare
Member
Author
ekohl
commented
Jan 10, 2024
| test_dir = File.join(__dir__, '..', '..', 'test') | ||
| t.libs << ['test', test_dir] | ||
| t.pattern = "#{test_dir}/**/*_test.rb" | ||
| t.test_files = [Rails.root.join('test/unit/foreman/access_permissions_test.rb')] |
Member
Author
There was a problem hiding this comment.
There's a related discussion in theforeman/actions#16 on the best way to do this.
ekohl
commented
Jan 10, 2024
ekohl
force-pushed
the
reusable-workflows
branch
from
61bb4c6 to
ad9e31b
Compare
Closed
evgeni
reviewed
Jan 24, 2024
evgeni
reviewed
Jan 24, 2024
This moves the specific override to the test defined in rake. This means running test:foreman_ansible runs all required tests from core as well. The only downside it that running rake test will run the particular test twice.
This reduces the duplication between projects. For example, this ensures testing on Ruby 2.7 and NodeJS 14 which previously didn't happen.
ekohl
force-pushed
the
reusable-workflows
branch
from
ad9e31b to
872a733
Compare
Contributor
|
Can we merge this PR? |
evgeni
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the duplication between projects. For example, this ensures testing on Ruby 2.7 which previously didn't happen.
There are various preparation PRs, see the commits for details.
Right now this is incomplete because it loses the caching step that happens on a push to master. It also still uses the repository in my own namespace. This is just to see if it works.