Fixes #36913 - Set up GHA with matrix to run test on Ruby 2.7#9900
Merged
evgeni merged 1 commit intotheforeman:developfrom Nov 23, 2023
Merged
Fixes #36913 - Set up GHA with matrix to run test on Ruby 2.7#9900evgeni merged 1 commit intotheforeman:developfrom
evgeni merged 1 commit intotheforeman:developfrom
Conversation
Member
|
I wonder if it's updating Psych, or if libyaml on the Ubuntu-latest is newer than on our EL7 Jenkins nodes. That's the only thing I can think of |
evgeni
reviewed
Nov 11, 2023
ekohl
reviewed
Nov 15, 2023
ekohl
reviewed
Nov 15, 2023
Member
|
I decided to dive into the failure. As far as I can see it calls EL 8: # rpm -qv ruby ; rpm -qv libyaml
ruby-2.5.9-111.module_el8+475+35a6c697.x86_64
libyaml-0.1.7-5.el8.x86_64
# ruby -ryaml -e 'puts YAML.safe_load("{a:test}").inspect'
Traceback (most recent call last):
4: from -e:1:in `<main>'
3: from /usr/share/ruby/psych.rb:314:in `safe_load'
2: from /usr/share/ruby/psych.rb:350:in `parse'
1: from /usr/share/ruby/psych.rb:402:in `parse_stream'
/usr/share/ruby/psych.rb:402:in `parse': (<unknown>): found unexpected ':' while scanning a plain scalar at line 1 column 2 (Psych::SyntaxError)EL9 # rpm -qv ruby ; rpm -qv libyaml
ruby-3.0.4-160.el9.x86_64
libyaml-0.2.5-7.el9.x86_64
# ruby -ryaml -e 'puts YAML.safe_load("{a:test}").inspect'
{"a:test"=>nil}Ubuntu 20.04 # dpkg -l | grep -E 'libruby|libyaml'
ii libruby2.7:amd64 2.7.0-5ubuntu1.12 amd64 Libraries necessary to run Ruby 2.7
ii libyaml-0-2:amd64 0.2.2-1 amd64 Fast YAML 1.1 parser and emitter library
# ruby -ryaml -e 'puts YAML.safe_load("{a:test}").inspect'
{"a:test"=>nil}So I'm going to say it's a difference between libyaml 0.1.x and 0.2.x. |
ekohl
force-pushed
the
feat-36913-set-up-gha-2.7
branch
from
894bd7f to
6fefa32
Compare
Member
|
I took the liberty of rebasing on #9908 and adding a commit that addresses the feedback to see if that works. |
Member
Author
|
#9908 was merged, so this needs a rebase I guess. |
evgeni
force-pushed
the
feat-36913-set-up-gha-2.7
branch
from
6fefa32 to
7484c4a
Compare
Member
done and applied my nitpicks |
evgeni
approved these changes
Nov 23, 2023
Co-Authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl> Co-Authored-by: Evgeni Golov <evgeni@golov.de>
evgeni
force-pushed
the
feat-36913-set-up-gha-2.7
branch
from
7484c4a to
c186ca9
Compare
Member
|
And theforeman/actions#19 makes use of the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of #9871.